polish

Author: chillaq

lib/splitclient-rb.rb

@@ -105,6 +105,7 @@
 require 'splitclient-rb/engine/metrics/binary_search_latency_tracker'
 require 'splitclient-rb/engine/models/split'
 require 'splitclient-rb/engine/models/label'
+require 'splitclient-rb/engine/models/segment_type'
 require 'splitclient-rb/engine/models/treatment'
 require 'splitclient-rb/engine/auth_api_client'
 require 'splitclient-rb/engine/back_off'

lib/splitclient-rb/engine/matchers/rule_based_segment_matcher.rb

@@ -44,9 +44,9 @@ def match?(args)
 
     def check_excluded_segments(rule_based_segment, key, args)
       rule_based_segment[:excluded][:segments].each do |segment|
-        return false if segment[:type] == 'standard' && @segments_repository.in_segment?(segment[:name], key)
+        return false if segment[:type] == SplitIoClient::Engine::Models::SegmentType::STANDARD && @segments_repository.in_segment?(segment[:name], key)
 
-        return false if segment[:type] == 'rule-based' && match_rbs(
+        return false if segment[:type] == SplitIoClient::Engine::Models::SegmentType::RULE_BASED_SEGMENT && match_rbs(
           @rule_based_segments_repository.get_rule_based_segment(segment[:name]), args
         )
       end

lib/splitclient-rb/engine/models/segment_type.rb

@@ -0,0 +1,4 @@
+class SplitIoClient::Engine::Models::SegmentType
+  STANDARD = 'standard'
+  RULE_BASED_SEGMENT = 'rule-based'
+end

lib/splitclient-rb/helpers/util.rb

@@ -17,7 +17,7 @@ def self.segment_names_in_rb_segment(object, matcher_type)
         names = Set.new 
         names.merge segment_names_by_object(object, matcher_type)
         object[:excluded][:segments].each do |segment|
-            if segment[:type] == 'standard'
+            if segment[:type] == SplitIoClient::Engine::Models::SegmentType::STANDARD
               names.add(segment[:name])
             end
         end