Merge branch 'feature/prerequisites' into T-FME-4160-prereq-integrations

Author: chillaq

lib/splitclient-rb/engine/models/label.rb

@@ -6,5 +6,4 @@ class SplitIoClient::Engine::Models::Label
   NOT_IN_SPLIT = 'not in split'.freeze
   NOT_READY = 'not ready'.freeze
   NOT_FOUND = 'definition not found'.freeze
-  PREREQUISITES_NOT_MET = 'prerequisites not met'.freeze
 end

spec/engine/parser/evaluator_spec.rb

@@ -3,13 +3,12 @@
 require 'spec_helper'
 
 describe SplitIoClient::Engine::Parser::Evaluator do
-  let(:config) { SplitIoClient::SplitConfig.new(logger: Logger.new(StringIO.new)) }
-  let(:segments_repository) { SplitIoClient::Cache::Repositories::SegmentsRepository.new(config) }
-  let(:rule_based_segments_repository) { SplitIoClient::Cache::Repositories::RuleBasedSegmentsRepository.new(config) }
+  let(:segments_repository) { SplitIoClient::Cache::Repositories::SegmentsRepository.new(@default_config) }
+  let(:rule_based_segments_repository) { SplitIoClient::Cache::Repositories::RuleBasedSegmentsRepository.new(@default_config) }
   let(:flag_sets_repository) {SplitIoClient::Cache::Repositories::MemoryFlagSetsRepository.new([])}
   let(:flag_set_filter) {SplitIoClient::Cache::Filter::FlagSetsFilter.new([])}
-  let(:splits_repository) { SplitIoClient::Cache::Repositories::SplitsRepository.new(config, flag_sets_repository, flag_set_filter) }
-  let(:evaluator) { described_class.new(segments_repository, splits_repository, rule_based_segments_repository, config) }
+  let(:splits_repository) { SplitIoClient::Cache::Repositories::SplitsRepository.new(@default_config, flag_sets_repository, flag_set_filter) }
+  let(:evaluator) { described_class.new(segments_repository, splits_repository, rule_based_segments_repository, true) }
 
   let(:killed_split) { { killed: true, defaultTreatment: 'default' } }
   let(:archived_split) { { status: 'ARCHIVED' } }
@@ -18,11 +17,6 @@
                            SplitIoClient.root, 'spec/test_data/splits/engine/dependency_matcher.json'
                          )), symbolize_names: true)
   end
-  let(:split_data_prereq) do
-    JSON.parse(File.read(File.join(
-                           SplitIoClient.root, 'spec/test_data/splits/engine/prerequisites_matcher.json'
-                         )), symbolize_names: true)
-  end
 
   it 'returns killed treatment' do
     expect(evaluator.evaluate_feature_flag({ matching_key: 'foo' }, killed_split))
@@ -46,16 +40,4 @@
       evaluator.evaluate_feature_flag({ bucketing_key: nil, matching_key: 'fake_user_id_1' }, split_data[:ff][:d][1])
     end
   end
-
-  context 'prerequisites matcher' do
-    it 'test match' do
-      splits_repository.update([split_data_prereq[:ff][:d][0], split_data_prereq[:ff][:d][1]], [], 1234)
-
-      result = evaluator.evaluate_feature_flag({ bucketing_key: nil, matching_key: 'fake_user' }, 'test_prereq')
-      expect(result[:treatment]).to eq('off_default')
-
-      result = evaluator.evaluate_feature_flag({ bucketing_key: nil, matching_key: 'fake_user_id_1' }, 'test_prereq')
-      expect(result[:treatment]).to eq('on')
-    end
-  end
 end