polish

Author: Bilal Al

lib/splitclient-rb/engine/common/impressions_manager.rb

@@ -21,7 +21,7 @@ def initialize(config,
         def build_impression(matching_key, bucketing_key, split_name, treatment, impressions_disabled, params = {})
           impression_data = impression_data(matching_key, bucketing_key, split_name, treatment, params[:time])
           begin
-            if @config.impressions_mode == :none || impressions_disabled # In NONE mode we should track the total amount of evaluations and the unique keys.
+            if @config.impressions_mode == :none || impressions_disabled
               @impression_counter.inc(split_name, impression_data[:m])
               @unique_keys_tracker.track(split_name, matching_key)
             elsif @config.impressions_mode == :debug #  In DEBUG mode we should calculate the pt only.
@@ -43,11 +43,11 @@ def track(impressions_decorator)
           impressions_decorator.each do |impression_decorator|
             stats = { dropped: 0, queued: 0, dedupe: 0 }
             begin
-              if @config.impressions_mode == :none || impression_decorator[:disabled]
-                return
-              elsif @config.impressions_mode == :debug
+              next if @config.impressions_mode == :none || impression_decorator[:disabled]
+
+              if @config.impressions_mode == :debug
                 track_debug_mode([impression_decorator[:impression]], stats)
-              elsif @config.impressions_mode == :optimized
+              else
                 track_optimized_mode([impression_decorator[:impression]], stats)
               end
             rescue StandardError => e

lib/splitclient-rb/helpers/repository_helper.rb

@@ -15,7 +15,9 @@ def self.update_feature_flag_repository(feature_flag_repository, feature_flags,
 
           unless feature_flag.key?(:impressionsDisabled)
             feature_flag[:impressionsDisabled] = false
-            config.logger.debug("feature flag (#{feature_flag[:name]}) does not have `impressionsDisabled` field, setting it to `false`") if config.debug_enabled
+            if config.debug_enabled
+              config.logger.debug("feature flag (#{feature_flag[:name]}) does not have impressionsDisabled field, setting it to false")
+            end
           end
 
           config.logger.debug("storing feature flag (#{feature_flag[:name]})") if config.debug_enabled