Skip to content

Commit 4c9e171

Browse files
author
Bilal Al
committed
fixed join timeout
1 parent 58512ba commit 4c9e171

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

lib/splitclient-rb/clients/split_client.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -103,12 +103,12 @@ def destroy
103103
sleep(0.1)
104104
if !@config.threads.key?(:impressions_sender) || !@config.threads.key?(:events_sender)
105105
@config.logger.debug("Periodic data recording thread has not started yet, waiting for service startup.")
106-
@config.threads[:start_sdk].join if @config.threads.key?(:start_sdk)
106+
@config.threads[:start_sdk].join(5) if @config.threads.key?(:start_sdk)
107107
end
108108
end
109109
@config.threads.select { |name, thread| name.to_s.end_with? 'sender' }.values.each do |thread|
110110
thread.raise(SplitIoClient::SDKShutdownException)
111-
thread.join(5)
111+
thread.join
112112
end
113113

114114
@config.threads.values.each { |thread| Thread.kill(thread) }

0 commit comments

Comments
 (0)