polish

Author: Bilal Al

lib/splitclient-rb/engine/matchers/equal_to_semver_matcher.rb

@@ -20,7 +20,7 @@ def match?(args)
 
       value_to_match = args[:attributes][@attribute.to_sym]
       unless value_to_match.is_a?(String)
-        @logger.error('stringMatcherData is required for EQUAL_TO_SEMVER matcher type')
+        @logger.log_if_debug('stringMatcherData is required for EQUAL_TO_SEMVER matcher type')
         return false
       end
       matches = @semver.compare(SplitIoClient::Semver.new(value_to_match)).zero?

spec/engine/matchers/matches_equal_to_semver_matcher_spec.rb

@@ -28,4 +28,11 @@
     expect(matcher.match?(:attributes=>{"version": "2.1.5"})).to eq(false)
     expect(matcher.match?(:attributes=>{"version": "2.1.5-rc1"})).to eq(false)
   end
+
+  it 'invalid attribute' do
+    matcher = described_class.new("version", raw[:stringMatcherData], config.split_logger, config.split_validator)
+    expect(matcher.match?(:attributes=>{"version": 2.1})).to eq(false)
+    expect(matcher.match?(:attributes=>{"version": nil})).to eq(false)
+  end
+
 end