Skip to content

Commit 28bdff9

Browse files
authored
Merge pull request #570 from splitio/fix-rbs-repository
fix rbs repository
2 parents d0dd013 + db90929 commit 28bdff9

File tree

2 files changed

+7
-1
lines changed

2 files changed

+7
-1
lines changed

lib/splitclient-rb/cache/repositories/rule_based_segments_repository.rb

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,8 @@ def clear
8585

8686
def contains?(segment_names)
8787
return false if rule_based_segment_names.empty?
88-
return set(segment_names).subset?(rule_based_segment_names)
88+
89+
return segment_names.to_set.subset?(rule_based_segment_names.to_set)
8990
end
9091

9192
private

spec/cache/repositories/rule_based_segments_repository_spec.rb

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,11 @@
4040
)
4141
end
4242

43+
it 'contains' do
44+
expect(repository.contains?(['foo', 'bar'].to_set)).to eq(true)
45+
expect(repository.contains?(['foo', 'oof'].to_set)).to eq(false)
46+
end
47+
4348
it 'remove undefined matcher with template condition' do
4449
rule_based_segment = { name: 'corge', trafficTypeName: 'tt_name_5', conditions: [
4550
{

0 commit comments

Comments
 (0)