rc

Author: EmilianoSanchez

package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "@splitsoftware/splitio-sync-tools",
-  "version": "0.7.0",
+  "version": "1.0.0-rc.0",
   "description": "Split JavaScript Sync Tools",
   "main": "lib/cjs/index.js",
   "module": "lib/esm/index.js",

package.json

@@ -2,8 +2,10 @@ import { splitApiFactory } from '@splitsoftware/splitio-commons/src/services/spl
 import { ISplitApi } from '@splitsoftware/splitio-commons/src/services/types';
 import { IStorageAsync, ITelemetryCacheAsync } from '@splitsoftware/splitio-commons/src/storages/types';
 import { ISettings } from '@splitsoftware/splitio-commons/src/types';
-import { SegmentsSynchronizer } from './synchronizers/SegmentsSynchronizer';
-import { SplitsSynchronizer } from './synchronizers/SplitsSynchronizer';
+import { segmentChangesFetcherFactory } from '@splitsoftware/splitio-commons/src/sync/polling/fetchers/segmentChangesFetcher';
+import { segmentChangesUpdaterFactory } from '@splitsoftware/splitio-commons/src/sync/polling/updaters/segmentChangesUpdater';
+import { splitChangesFetcherFactory } from '@splitsoftware/splitio-commons/src/sync/polling/fetchers/splitChangesFetcher';
+import { splitChangesUpdaterFactory } from '@splitsoftware/splitio-commons/src/sync/polling/updaters/splitChangesUpdater';
 import { synchronizerStorageFactory } from './storages/synchronizerStorage';
 import { eventsSubmitterFactory } from './submitters/eventsSubmitter';
 import { impressionsSubmitterFactory } from './submitters/impressionsSubmitter';
@@ -36,13 +38,13 @@ export class Synchronizer {
    */
   private _splitApi: ISplitApi;
   /**
-   * The local reference to the SegmentsUpdater instance from `@splitio/javascript-commons`.
+   * The local reference to the segmentChangesUpdater instance from `@splitio/javascript-commons`.
    */
-  private _segmentsSynchronizer!: SegmentsSynchronizer;
+  private _segmentChangesUpdater!: ReturnType<typeof segmentChangesUpdaterFactory>;
   /**
-   * The local reference to the SplitUpdater instance from `@splitio/javascript-commons`.
+   * The local reference to the splitChangesUpdater instance from `@splitio/javascript-commons`.
    */
-  private _splitsSynchronizer!: SplitsSynchronizer;
+  private _splitChangesUpdater!: ReturnType<typeof splitChangesUpdaterFactory>;
   /**
    * The local reference to the EventsSynchronizer class.
    */
@@ -137,15 +139,16 @@ export class Synchronizer {
       new ImpressionCountsCacheInMemory() :
       undefined;
 
-    this._segmentsSynchronizer = new SegmentsSynchronizer(
-      this._splitApi.fetchSegmentChanges,
-      this.settings,
+    this._segmentChangesUpdater = segmentChangesUpdaterFactory(
+      this.settings.log,
+      segmentChangesFetcherFactory(this._splitApi.fetchSegmentChanges),
       this._storage.segments,
     );
-    this._splitsSynchronizer = new SplitsSynchronizer(
-      this._splitApi.fetchSplitChanges,
-      this.settings,
+    this._splitChangesUpdater = splitChangesUpdaterFactory(
+      this.settings.log,
+      splitChangesFetcherFactory(this._splitApi.fetchSplitChanges, this.settings, this._storage),
       this._storage,
+      this.settings.sync.__splitFiltersValidation
     );
     this._eventsSubmitter = eventsSubmitterFactory(
       this.settings.log,
@@ -260,11 +263,10 @@ export class Synchronizer {
   private async executeSplitsAndSegments(standalone = true) {
     if (standalone) await this.preExecute();
 
-    // @TODO optimize SplitChangesUpdater to reduce storage operations ("inMemoryOperation" mode)
-    const isSplitsSyncSuccessful = await this._splitsSynchronizer.getSplitChanges();
+    const isSplitsSyncSuccessful = await this._splitChangesUpdater();
 
     this.settings.log.debug(`Feature flags Synchronizer task: ${isSplitsSyncSuccessful ? 'Successful' : 'Unsuccessful'}`);
-    const isSegmentsSyncSuccessful = await this._segmentsSynchronizer.getSegmentsChanges();
+    const isSegmentsSyncSuccessful = await this._segmentChangesUpdater();
     this.settings.log.debug(`Segments Synchronizer task: ${isSegmentsSyncSuccessful ? 'Successful' : 'Unsuccessful'}`);
 
     if (standalone) await this.postExecute();

src/Synchronizer.ts

@@ -53,7 +53,7 @@ export function synchronizerSettingsValidator(
   const { scheduler, log } = settings;
 
   // @TODO validate synchronizerMode eventually
-  // @TODO: validate minimum and maximum value for config params.
+  // @TODO validate minimum and maximum value for config params.
   scheduler.eventsPerPost = validatePositiveInteger(log, 'eventsPerPost', scheduler.eventsPerPost, defaults.scheduler.eventsPerPost);
   scheduler.impressionsPerPost = validatePositiveInteger(log, 'impressionsPerPost', scheduler.impressionsPerPost, defaults.scheduler.impressionsPerPost);
   scheduler.maxRetries = validatePositiveInteger(log, 'maxRetries', scheduler.maxRetries, defaults.scheduler.maxRetries);