Skip to content

[Rule-based segments] Polishing #402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 14, 2025
Merged

[Rule-based segments] Polishing #402

merged 4 commits into from
Apr 14, 2025

Conversation

@EmilianoSanchez
Copy link
Contributor

@EmilianoSanchez EmilianoSanchez commented Apr 3, 2025 •
edited
Loading

JavaScript commons library

What did you accomplish?

  • Handle optional conditions and excluded properties in rule-based segments.
  • Updates for cache expiration and clean-up when using Local Storage.

How do we test the changes introduced in this PR?

Extra Notes

@EmilianoSanchez EmilianoSanchez requested a review from a team as a code owner April 3, 2025 14:49
@EmilianoSanchez EmilianoSanchez merged commit 2228b93 into rb_segments_baseline Apr 14, 2025
1 check passed
@EmilianoSanchez EmilianoSanchez deleted the rb_segments_polishing branch April 14, 2025 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sanzmauro sanzmauro sanzmauro approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@EmilianoSanchez @sanzmauro