RBS excluded segments

Author: ZamoraEmmanuel

src/dtos/types.ts

@@ -199,14 +199,19 @@ export interface ISplitCondition {
   conditionType?: 'ROLLOUT' | 'WHITELIST'
 }
 
+export interface IExcludedSegments {
+  type: string,
+  name: string,
+}
+
 export interface IRBSegment {
   name: string,
   changeNumber: number,
   status: 'ACTIVE' | 'ARCHIVED',
   conditions?: ISplitCondition[],
   excluded?: {
     keys?: string[],
-    segments?: string[]
+    segments?: IExcludedSegments[]
   }
 }
 

src/evaluator/matchers/__tests__/rbsegment.spec.ts

@@ -24,7 +24,9 @@ const STORED_RBSEGMENTS: Record<string, IRBSegment> = {
     status: 'ACTIVE',
     excluded: {
       keys: ['[email protected]', '[email protected]'],
-      segments: ['segment_test']
+      segments: [
+        { type: 'regular', name: 'segment_test' }
+      ]
     },
     conditions: [
       {

src/evaluator/matchers/rbsegment.ts

@@ -35,8 +35,8 @@ export function ruleBasedSegmentMatcherContext(segmentName: string, storage: ISt
 
       if (excluded.keys && excluded.keys.indexOf(matchingKey) !== -1) return true;
 
-      const isInSegment = (excluded.segments || []).map(segmentName => {
-        return storage.segments.isInSegment(segmentName, matchingKey);
+      const isInSegment = (excluded.segments || []).map(segment => {
+        return storage.segments.isInSegment(segment.name, matchingKey);
       });
 
       return isInSegment.length && thenable(isInSegment[0]) ?

src/sync/polling/updaters/splitChangesUpdater.ts

@@ -31,7 +31,10 @@ function checkAllSegmentsExist(segments: ISegmentsCacheBase): Promise<boolean> {
  */
 export function parseSegments(ruleEntity: ISplit | IRBSegment, matcherType: typeof IN_SEGMENT | typeof IN_RULE_BASED_SEGMENT = IN_SEGMENT): Set<string> {
   const { conditions = [], excluded } = ruleEntity as IRBSegment;
-  const segments = new Set<string>(excluded && excluded.segments);
+
+  const segments = new Set<string>(
+    excluded?.segments?.map(segment => segment.name) || []
+  );
 
   for (let i = 0; i < conditions.length; i++) {
     const matchers = conditions[i].matcherGroup.matchers;