Refactor test function syntax to use arrow functions for consistency

EmilianoSanchez · EmilianoSanchez · commit cf8c517bd1a8 · 2025-03-18T19:20:11.000-03:00
diff --git a/src/evaluator/__tests__/evaluate-feature.spec.ts b/src/evaluator/__tests__/evaluate-feature.spec.ts
@@ -25,7 +25,7 @@ const mockStorage = {
   }
 };
 
-test('EVALUATOR / should return label exception, treatment control and config null on error', async function () {
+test('EVALUATOR / should return label exception, treatment control and config null on error', async () => {
   const expectedOutput = {
     treatment: 'control',
     label: EXCEPTION,
@@ -46,7 +46,7 @@ test('EVALUATOR / should return label exception, treatment control and config nu
 });
 
 
-test('EVALUATOR / should return right label, treatment and config if storage returns without errors.', async function () {
+test('EVALUATOR / should return right label, treatment and config if storage returns without errors.', async () => {
   const expectedOutput = {
     treatment: 'on', label: 'in segment all',
     config: '{color:\'black\'}', changeNumber: 1487277320548
diff --git a/src/evaluator/__tests__/evaluate-features.spec.ts b/src/evaluator/__tests__/evaluate-features.spec.ts
@@ -42,7 +42,7 @@ const mockStorage = {
   }
 };
 
-test('EVALUATOR - Multiple evaluations at once  / should return label exception, treatment control and config null on error', async function () {
+test('EVALUATOR - Multiple evaluations at once  / should return label exception, treatment control and config null on error', async () => {
   const expectedOutput = {
     throw_exception: {
       treatment: 'control',
@@ -65,7 +65,7 @@ test('EVALUATOR - Multiple evaluations at once  / should return label exception,
 });
 
 
-test('EVALUATOR - Multiple evaluations at once / should return right labels, treatments and configs if storage returns without errors.', async function () {
+test('EVALUATOR - Multiple evaluations at once / should return right labels, treatments and configs if storage returns without errors.', async () => {
   const expectedOutput = {
     config: {
       treatment: 'on', label: 'in segment all',
diff --git a/src/evaluator/combiners/__tests__/and.spec.ts b/src/evaluator/combiners/__tests__/and.spec.ts
@@ -1,14 +1,14 @@
 import { andCombinerContext } from '../and';
 import { loggerMock } from '../../../logger/__tests__/sdkLogger.mock';
 
-test('COMBINER AND / should always return true', async function () {
+test('COMBINER AND / should always return true', async () => {
 
   let AND = andCombinerContext(loggerMock, [() => true, () => true, () => true]);
 
   expect(await AND('always true')).toBe(true); // should always return true
 });
 
-test('COMBINER AND / should always return false', async function () {
+test('COMBINER AND / should always return false', async () => {
 
   let AND = andCombinerContext(loggerMock, [() => true, () => true, () => false]);
 
diff --git a/src/evaluator/combiners/__tests__/ifelseif.spec.ts b/src/evaluator/combiners/__tests__/ifelseif.spec.ts
@@ -2,7 +2,7 @@
 import { ifElseIfCombinerContext } from '../ifelseif';
 import { loggerMock } from '../../../logger/__tests__/sdkLogger.mock';
 
-test('IF ELSE IF COMBINER / should correctly propagate context parameters and predicates returns value', async function () {
+test('IF ELSE IF COMBINER / should correctly propagate context parameters and predicates returns value', async () => {
   let inputKey = 'sample';
   let inputSeed = 1234;
   let inputAttributes = {};
@@ -20,10 +20,9 @@ test('IF ELSE IF COMBINER / should correctly propagate context parameters and pr
   let ifElseIfEvaluator = ifElseIfCombinerContext(loggerMock, predicates);
 
   expect(await ifElseIfEvaluator(inputKey, inputSeed, inputAttributes) === evaluationResult).toBe(true);
-  console.log(`evaluator should return ${evaluationResult}`);
 });
 
-test('IF ELSE IF COMBINER / should stop evaluating when one matcher return a treatment', async function () {
+test('IF ELSE IF COMBINER / should stop evaluating when one matcher return a treatment', async () => {
   let predicates = [
     function undef() {
       return undefined;
@@ -41,7 +40,7 @@ test('IF ELSE IF COMBINER / should stop evaluating when one matcher return a tre
   expect(await ifElseIfEvaluator()).toBe('exclude'); // exclude treatment found
 });
 
-test('IF ELSE IF COMBINER / should return undefined if there is none matching rule', async function () {
+test('IF ELSE IF COMBINER / should return undefined if there is none matching rule', async () => {
   const predicates = [
     function undef() {
       return undefined;
diff --git a/src/evaluator/matchers/__tests__/all.spec.ts b/src/evaluator/matchers/__tests__/all.spec.ts
@@ -3,7 +3,7 @@ import { matcherFactory } from '..';
 import { IMatcher, IMatcherDto } from '../../types';
 import { loggerMock } from '../../../logger/__tests__/sdkLogger.mock';
 
-test('MATCHER ALL_KEYS / should always return true', function () {
+test('MATCHER ALL_KEYS / should always return true', () => {
   const matcher = matcherFactory(loggerMock, {
     type: matcherTypes.ALL_KEYS,
     value: undefined
diff --git a/src/evaluator/matchers/__tests__/between.spec.ts b/src/evaluator/matchers/__tests__/between.spec.ts
@@ -3,7 +3,7 @@ import { matcherFactory } from '..';
 import { IMatcher, IMatcherDto } from '../../types';
 import { loggerMock } from '../../../logger/__tests__/sdkLogger.mock';
 
-test('MATCHER BETWEEN / should return true ONLY when the value is between 10 and 20', function () {
+test('MATCHER BETWEEN / should return true ONLY when the value is between 10 and 20', () => {
   const matcher = matcherFactory(loggerMock, {
     negate: false,
     type: matcherTypes.BETWEEN,
diff --git a/src/evaluator/matchers/__tests__/boolean.spec.ts b/src/evaluator/matchers/__tests__/boolean.spec.ts
@@ -3,7 +3,7 @@ import { matcherFactory } from '..';
 import { IMatcher, IMatcherDto } from '../../types';
 import { loggerMock } from '../../../logger/__tests__/sdkLogger.mock';
 
-test('MATCHER BOOLEAN / should return true ONLY when the value is true', function () {
+test('MATCHER BOOLEAN / should return true ONLY when the value is true', () => {
   const matcher = matcherFactory(loggerMock, {
     type: matcherTypes.EQUAL_TO_BOOLEAN,
     value: true
diff --git a/src/evaluator/matchers/__tests__/cont_all.spec.ts b/src/evaluator/matchers/__tests__/cont_all.spec.ts
@@ -3,7 +3,7 @@ import { matcherFactory } from '..';
 import { IMatcher, IMatcherDto } from '../../types';
 import { loggerMock } from '../../../logger/__tests__/sdkLogger.mock';
 
-test('MATCHER CONTAINS_ALL_OF_SET / should return true ONLY when value contains all of set ["update", "add"]', function () {
+test('MATCHER CONTAINS_ALL_OF_SET / should return true ONLY when value contains all of set ["update", "add"]', () => {
   const matcher = matcherFactory(loggerMock, {
     negate: false,
     type: matcherTypes.CONTAINS_ALL_OF_SET,
diff --git a/src/evaluator/matchers/__tests__/cont_any.spec.ts b/src/evaluator/matchers/__tests__/cont_any.spec.ts
@@ -3,7 +3,7 @@ import { matcherFactory } from '..';
 import { IMatcher, IMatcherDto } from '../../types';
 import { loggerMock } from '../../../logger/__tests__/sdkLogger.mock';
 
-test('MATCHER CONTAINS_ANY_OF_SET / should return true ONLY when value contains any of set ["update", "add"]', function () {
+test('MATCHER CONTAINS_ANY_OF_SET / should return true ONLY when value contains any of set ["update", "add"]', () => {
   const matcher = matcherFactory(loggerMock, {
     negate: false,
     type: matcherTypes.CONTAINS_ANY_OF_SET,
diff --git a/src/evaluator/matchers/__tests__/cont_str.spec.ts b/src/evaluator/matchers/__tests__/cont_str.spec.ts
@@ -3,7 +3,7 @@ import { matcherFactory } from '..';
 import { IMatcher, IMatcherDto } from '../../types';
 import { loggerMock } from '../../../logger/__tests__/sdkLogger.mock';
 
-test('MATCHER CONTAINS_STRING / should return true ONLY when the value is contained in ["roni", "bad", "ar"]', function () {
+test('MATCHER CONTAINS_STRING / should return true ONLY when the value is contained in ["roni", "bad", "ar"]', () => {
   const matcher = matcherFactory(loggerMock, {
     negate: false,
     type: matcherTypes.CONTAINS_STRING,
diff --git a/src/evaluator/matchers/__tests__/dependency.spec.ts b/src/evaluator/matchers/__tests__/dependency.spec.ts
@@ -18,7 +18,7 @@ const mockStorage = {
   }
 };
 
-test('MATCHER IN_SPLIT_TREATMENT / should return true ONLY when parent split returns one of the expected treatments', function () {
+test('MATCHER IN_SPLIT_TREATMENT / should return true ONLY when parent split returns one of the expected treatments', () => {
   const matcherTrueAlwaysOn = matcherFactory(loggerMock, {
     type: matcherTypes.IN_SPLIT_TREATMENT,
     value: {
@@ -57,7 +57,7 @@ test('MATCHER IN_SPLIT_TREATMENT / should return true ONLY when parent split ret
   expect(matcherFalseAlwaysOff({ key: 'a-key' }, evaluateFeature)).toBe(false); // Parent split returns treatment "on", but we are expecting ["off", "v1"], so the matcher returns false
 });
 
-test('MATCHER IN_SPLIT_TREATMENT / Edge cases', function () {
+test('MATCHER IN_SPLIT_TREATMENT / Edge cases', () => {
   const matcherParentNotExist = matcherFactory(loggerMock, {
     type: matcherTypes.IN_SPLIT_TREATMENT,
     value: {
diff --git a/src/evaluator/matchers/__tests__/eq.spec.ts b/src/evaluator/matchers/__tests__/eq.spec.ts
@@ -3,7 +3,7 @@ import { matcherFactory } from '..';
 import { IMatcher, IMatcherDto } from '../../types';
 import { loggerMock } from '../../../logger/__tests__/sdkLogger.mock';
 
-test('MATCHER EQUAL / should return true ONLY when the value is equal to 10', function () {
+test('MATCHER EQUAL / should return true ONLY when the value is equal to 10', () => {
   const matcher = matcherFactory(loggerMock, {
     negate: false,
     type: matcherTypes.EQUAL_TO,
diff --git a/src/evaluator/matchers/__tests__/eq_set.spec.ts b/src/evaluator/matchers/__tests__/eq_set.spec.ts
@@ -3,7 +3,7 @@ import { matcherFactory } from '..';
 import { IMatcher, IMatcherDto } from '../../types';
 import { loggerMock } from '../../../logger/__tests__/sdkLogger.mock';
 
-test('MATCHER EQUAL_TO_SET / should return true ONLY when value is equal to set ["update", "add"]', function () {
+test('MATCHER EQUAL_TO_SET / should return true ONLY when value is equal to set ["update", "add"]', () => {
   const matcher = matcherFactory(loggerMock, {
     negate: false,
     type: matcherTypes.EQUAL_TO_SET,
diff --git a/src/evaluator/matchers/__tests__/ew.spec.ts b/src/evaluator/matchers/__tests__/ew.spec.ts
@@ -3,7 +3,7 @@ import { matcherFactory } from '..';
 import { IMatcher, IMatcherDto } from '../../types';
 import { loggerMock } from '../../../logger/__tests__/sdkLogger.mock';
 
-test('MATCHER ENDS_WITH / should return true ONLY when the value ends with ["a", "b", "c"]', function () {
+test('MATCHER ENDS_WITH / should return true ONLY when the value ends with ["a", "b", "c"]', () => {
   const matcher = matcherFactory(loggerMock, {
     negate: false,
     type: matcherTypes.ENDS_WITH,
@@ -17,7 +17,7 @@ test('MATCHER ENDS_WITH / should return true ONLY when the value ends with ["a",
   expect(matcher('manager')).toBe(false); // manager doesn't end with ["a", "b", "c"]
 });
 
-test('MATCHER ENDS_WITH / should return true ONLY when the value ends with ["demo.test.org"]', function () {
+test('MATCHER ENDS_WITH / should return true ONLY when the value ends with ["demo.test.org"]', () => {
   const matcher = matcherFactory(loggerMock, {
     negate: false,
     type: matcherTypes.ENDS_WITH,
diff --git a/src/evaluator/matchers/__tests__/gte.spec.ts b/src/evaluator/matchers/__tests__/gte.spec.ts
@@ -3,7 +3,7 @@ import { matcherFactory } from '..';
 import { IMatcher, IMatcherDto } from '../../types';
 import { loggerMock } from '../../../logger/__tests__/sdkLogger.mock';
 
-test('MATCHER GREATER THAN OR EQUAL / should return true ONLY when the value is greater than or equal to 10', function () {
+test('MATCHER GREATER THAN OR EQUAL / should return true ONLY when the value is greater than or equal to 10', () => {
   const matcher = matcherFactory(loggerMock, {
     negate: false,
     type: matcherTypes.GREATER_THAN_OR_EQUAL_TO,
diff --git a/src/evaluator/matchers/__tests__/lte.spec.ts b/src/evaluator/matchers/__tests__/lte.spec.ts
@@ -3,7 +3,7 @@ import { matcherFactory } from '..';
 import { IMatcher, IMatcherDto } from '../../types';
 import { loggerMock } from '../../../logger/__tests__/sdkLogger.mock';
 
-test('MATCHER LESS THAN OR EQUAL / should return true ONLY when the value is less than or equal to 10', function () {
+test('MATCHER LESS THAN OR EQUAL / should return true ONLY when the value is less than or equal to 10', () => {
   const matcher = matcherFactory(loggerMock, {
     negate: false,
     type: matcherTypes.LESS_THAN_OR_EQUAL_TO,
diff --git a/src/evaluator/matchers/__tests__/part_of.spec.ts b/src/evaluator/matchers/__tests__/part_of.spec.ts
@@ -3,7 +3,7 @@ import { matcherFactory } from '..';
 import { IMatcher, IMatcherDto } from '../../types';
 import { loggerMock } from '../../../logger/__tests__/sdkLogger.mock';
 
-test('MATCHER PART_OF_SET / should return true ONLY when value is part of of set ["update", "add", "delete"]', function () {
+test('MATCHER PART_OF_SET / should return true ONLY when value is part of of set ["update", "add", "delete"]', () => {
   const matcher = matcherFactory(loggerMock, {
     negate: false,
     type: matcherTypes.PART_OF_SET,
diff --git a/src/evaluator/matchers/__tests__/segment/client_side.spec.ts b/src/evaluator/matchers/__tests__/segment/client_side.spec.ts
@@ -4,7 +4,7 @@ import { IMatcher, IMatcherDto } from '../../../types';
 import { IStorageSync } from '../../../../storages/types';
 import { loggerMock } from '../../../../logger/__tests__/sdkLogger.mock';
 
-test('MATCHER IN_SEGMENT / should return true ONLY when the segment is defined inside the segment storage', async function () {
+test('MATCHER IN_SEGMENT / should return true ONLY when the segment is defined inside the segment storage', async () => {
   const segment = 'employees';
 
   const matcherTrue = matcherFactory(loggerMock, {
@@ -33,7 +33,7 @@ test('MATCHER IN_SEGMENT / should return true ONLY when the segment is defined i
   expect(await matcherFalse('key')).toBe(false); // segment not found in mySegments list
 });
 
-test('MATCHER IN_LARGE_SEGMENT / should return true ONLY when the segment is defined inside the segment storage', async function () {
+test('MATCHER IN_LARGE_SEGMENT / should return true ONLY when the segment is defined inside the segment storage', async () => {
   const segment = 'employees';
 
   const matcherTrue = matcherFactory(loggerMock, {
diff --git a/src/evaluator/matchers/__tests__/segment/server_side.spec.ts b/src/evaluator/matchers/__tests__/segment/server_side.spec.ts
@@ -4,7 +4,7 @@ import { IMatcher, IMatcherDto } from '../../../types';
 import { IStorageSync } from '../../../../storages/types';
 import { loggerMock } from '../../../../logger/__tests__/sdkLogger.mock';
 
-test('MATCHER IN_SEGMENT / should return true ONLY when the key is defined inside the segment', async function () {
+test('MATCHER IN_SEGMENT / should return true ONLY when the key is defined inside the segment', async () => {
   const segment = 'employees';
 
   const matcher = matcherFactory(loggerMock, {
diff --git a/src/evaluator/matchers/__tests__/sw.spec.ts b/src/evaluator/matchers/__tests__/sw.spec.ts
@@ -3,7 +3,7 @@ import { matcherFactory } from '..';
 import { IMatcher, IMatcherDto } from '../../types';
 import { loggerMock } from '../../../logger/__tests__/sdkLogger.mock';
 
-test('MATCHER STARTS_WITH / should return true ONLY when the value starts with ["a", "b", "c"]', function () {
+test('MATCHER STARTS_WITH / should return true ONLY when the value starts with ["a", "b", "c"]', () => {
   const matcher = matcherFactory(loggerMock, {
     negate: false,
     type: matcherTypes.STARTS_WITH,
diff --git a/src/evaluator/matchers/__tests__/whitelist.spec.ts b/src/evaluator/matchers/__tests__/whitelist.spec.ts
@@ -3,7 +3,7 @@ import { matcherFactory } from '..';
 import { IMatcher, IMatcherDto } from '../../types';
 import { loggerMock } from '../../../logger/__tests__/sdkLogger.mock';
 
-test('MATCHER WHITELIST / should return true ONLY when the value is in the list', function () {
+test('MATCHER WHITELIST / should return true ONLY when the value is in the list', () => {
   const matcher = matcherFactory(loggerMock, {
     type: matcherTypes.WHITELIST,
     value: ['key']
diff --git a/src/evaluator/matchersTransform/__tests__/segment.spec.ts b/src/evaluator/matchersTransform/__tests__/segment.spec.ts
@@ -1,6 +1,6 @@
 import { segmentTransform } from '../segment';
 
-test('TRANSFORMS / a segment object should be flatten to a string', function () {
+test('TRANSFORMS / a segment object should be flatten to a string', () => {
   const segmentName = 'employees';
   const sample = {
     segmentName
@@ -11,7 +11,7 @@ test('TRANSFORMS / a segment object should be flatten to a string', function ()
   expect(segmentName).toBe(plainSegmentName); // extracted segmentName matches
 });
 
-test('TRANSFORMS / if there is none segmentName entry, returns undefined', function () {
+test('TRANSFORMS / if there is none segmentName entry, returns undefined', () => {
   const sample = undefined;
   const undefinedSegmentName = segmentTransform(sample);
 
diff --git a/src/evaluator/matchersTransform/__tests__/whitelist.spec.ts b/src/evaluator/matchersTransform/__tests__/whitelist.spec.ts
@@ -1,6 +1,6 @@
 import { whitelistTransform } from '../whitelist';
 
-test('TRANSFORMS / the whitelist array should be extracted', function () {
+test('TRANSFORMS / the whitelist array should be extracted', () => {
   let sample = {
     whitelist: [
       'u1',
diff --git a/src/evaluator/parser/__tests__/boolean.spec.ts b/src/evaluator/parser/__tests__/boolean.spec.ts
@@ -4,7 +4,7 @@ import { ISplitCondition } from '../../../dtos/types';
 import { IEvaluation } from '../../types';
 import { loggerMock } from '../../../logger/__tests__/sdkLogger.mock';
 
-test('PARSER / if user.boolean is true then split 100%:on', async function () {
+test('PARSER / if user.boolean is true then split 100%:on', async () => {
 
   // @ts-ignore
   const evaluator = parser(loggerMock, [{
diff --git a/src/evaluator/parser/__tests__/index.spec.ts b/src/evaluator/parser/__tests__/index.spec.ts
diff --git a/src/evaluator/parser/__tests__/invalidMatcher.spec.ts b/src/evaluator/parser/__tests__/invalidMatcher.spec.ts
diff --git a/src/evaluator/parser/__tests__/regex.spec.ts b/src/evaluator/parser/__tests__/regex.spec.ts
diff --git a/src/evaluator/parser/__tests__/set.spec.ts b/src/evaluator/parser/__tests__/set.spec.ts
diff --git a/src/evaluator/parser/__tests__/string.spec.ts b/src/evaluator/parser/__tests__/string.spec.ts
diff --git a/src/evaluator/parser/__tests__/trafficAllocation.spec.ts b/src/evaluator/parser/__tests__/trafficAllocation.spec.ts
diff --git a/src/utils/promise/__tests__/wrapper.spec.ts b/src/utils/promise/__tests__/wrapper.spec.ts
