Skip to content

Commit 680b82d

Browse files
Update fetchSplitChanges method with rbSince param
1 parent 90697da commit 680b82d

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

src/services/__tests__/splitApi.spec.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -40,10 +40,10 @@ describe('splitApi', () => {
4040
assertHeaders(settings, headers);
4141
expect(url).toBe('sdk/segmentChanges/segmentName?since=-1&till=90');
4242

43-
splitApi.fetchSplitChanges(-1, false, 100);
43+
splitApi.fetchSplitChanges(-1, false, 100, -1);
4444
[url, { headers }] = fetchMock.mock.calls[3];
4545
assertHeaders(settings, headers);
46-
expect(url).toBe(expecteFlagsUrl(-1, 100, settings.validateFilters || false, settings));
46+
expect(url).toBe(expectedFlagsUrl(-1, 100, settings.validateFilters || false, settings, -1));
4747

4848
splitApi.postEventsBulk('fake-body');
4949
assertHeaders(settings, fetchMock.mock.calls[4][1].headers);
@@ -66,9 +66,9 @@ describe('splitApi', () => {
6666
fetchMock.mockClear();
6767

6868

69-
function expecteFlagsUrl(since: number, till: number, usesFilter: boolean, settings: ISettings) {
69+
function expectedFlagsUrl(since: number, till: number, usesFilter: boolean, settings: ISettings, rbSince?: number) {
7070
const filterQueryString = settings.sync.__splitFiltersValidation && settings.sync.__splitFiltersValidation.queryString;
71-
return `sdk/splitChanges?s=1.1&since=${since}${usesFilter ? filterQueryString : ''}${till ? '&till=' + till : ''}`;
71+
return `sdk/splitChanges?s=1.1&since=${since}${rbSince ? '&rbSince=' + rbSince : ''}${usesFilter ? filterQueryString : ''}${till ? '&till=' + till : ''}`;
7272
}
7373
});
7474

src/services/splitApi.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,8 +53,8 @@ export function splitApiFactory(
5353
return splitHttpClient(url, undefined, telemetryTracker.trackHttp(TOKEN));
5454
},
5555

56-
fetchSplitChanges(since: number, noCache?: boolean, till?: number) {
57-
const url = `${urls.sdk}/splitChanges?s=${flagSpecVersion}&since=${since}${filterQueryString || ''}${till ? '&till=' + till : ''}`;
56+
fetchSplitChanges(since: number, noCache?: boolean, till?: number, rbSince?: number) {
57+
const url = `${urls.sdk}/splitChanges?s=${flagSpecVersion}&since=${since}${rbSince ? '&rbSince=' + rbSince : ''}${filterQueryString || ''}${till ? '&till=' + till : ''}`;
5858
return splitHttpClient(url, noCache ? noCacheHeaderOptions : undefined, telemetryTracker.trackHttp(SPLITS))
5959
.catch((err) => {
6060
if (err.statusCode === 414) settings.log.error(ERROR_TOO_MANY_SETS);

0 commit comments

Comments
 (0)