Add tests

Author: EmilianoSanchez

src/__tests__/offline/node.spec.js

@@ -70,9 +70,16 @@ tape('Node.js Offline Mode', function (t) {
   t.test('Trying to specify an invalid extension it will timeout', assert => {
     const config = settingsGenerator('.forbidden');
 
-    sinon.spy(console, 'log');
-
-    const factory = SplitFactory({ ...config, debug: 'ERROR' }); // enable error level logs to check the message.
+    sinon.stub(console, 'error');
+    sinon.stub(console, 'warn');
+    sinon.stub(console, 'info');
+    sinon.stub(console, 'debug');
+
+    const factory = SplitFactory({
+      ...config,
+      debug: 'ERROR', // enable logs to check the message.
+      logger: console // use console as custom logger.
+    });
     const client = factory.client();
 
     client.on(client.Event.SDK_READY, () => {
@@ -84,9 +91,15 @@ tape('Node.js Offline Mode', function (t) {
     client.on(client.Event.SDK_READY_TIMED_OUT, () => {
       assert.pass('If tried to load a file with invalid extension, we should emit SDK_READY_TIMED_OUT.');
 
-      assert.ok(console.log.calledWithMatch(`[ERROR] splitio => sync:offline: There was an issue loading the mock feature flags data. No changes will be applied to the current cache. Error: Invalid extension specified for feature flags mock file. Accepted extensions are ".yml" and ".yaml". Your specified file is ${config.features}`));
+      assert.ok(console.error.calledWithMatch(`splitio => sync:offline: There was an issue loading the mock feature flags data. No changes will be applied to the current cache. Error: Invalid extension specified for feature flags mock file. Accepted extensions are ".yml" and ".yaml". Your specified file is ${config.features}`));
+      assert.notOk(console.warn.called, 'warn should not be called');
+      assert.ok(console.info.called, 'info should be called');
+      assert.ok(console.debug.called, 'debug should be called');
 
-      console.log.restore();
+      console.error.restore();
+      console.warn.restore();
+      console.info.restore();
+      console.debug.restore();
       client.destroy();
       assert.end();
     });

ts-tests/index.ts

@@ -49,6 +49,7 @@ let asyncManager: SplitIO.IAsyncManager;
 let browserClient: SplitIO.IBrowserClient;
 // Utility interfaces
 let impressionListener: SplitIO.IImpressionListener;
+let MyLogger: SplitIO.Logger = console;
 
 /**** Custom Types ****/
 
@@ -227,6 +228,7 @@ SDK.Logger.setLogLevel(SDK.Logger.LogLevel.WARN);
 SDK.Logger.setLogLevel(SDK.Logger.LogLevel.ERROR);
 SDK.Logger.setLogLevel(SDK.Logger.LogLevel.NONE);
 SDK.Logger.disable();
+SDK.Logger.setLogger(MyLogger);
 
 AsyncSDK.Logger.enable();
 AsyncSDK.Logger.setLogLevel(AsyncSDK.Logger.LogLevel.DEBUG);
@@ -235,6 +237,7 @@ AsyncSDK.Logger.setLogLevel(AsyncSDK.Logger.LogLevel.WARN);
 AsyncSDK.Logger.setLogLevel(AsyncSDK.Logger.LogLevel.ERROR);
 AsyncSDK.Logger.setLogLevel(AsyncSDK.Logger.LogLevel.NONE);
 AsyncSDK.Logger.disable();
+AsyncSDK.Logger.setLogger(MyLogger);
 
 /**** Tests for IClient interface ****/
 
@@ -571,6 +574,7 @@ let fullBrowserSettings: SplitIO.IBrowserSettings = {
   },
   impressionListener: impressionListener,
   debug: true,
+  logger: MyLogger,
   streamingEnabled: true,
   sync: {
     splitFilters: splitFilters,