Skip to content

Commit c1a531a

Browse files
committed
Updated test cases
1 parent 8ecf2ce commit c1a531a

File tree

2 files changed

+10
-10
lines changed

2 files changed

+10
-10
lines changed

dtos/fallbacktreatment.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ const (
66

77
type FallbackTreatment struct {
88
Treatment string
9-
Config string
9+
Config *string
1010
Label *string
1111
}
1212

dtos/fallbacktreatment_test.go

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -8,15 +8,15 @@ import (
88

99
func TestFallbackTreatmentCalculatorResolve(t *testing.T) {
1010
// Initial setup with both global and flag-specific treatments
11+
stringConfig := "flag1_config"
1112
config := &FallbackTreatmentConfig{
1213
GlobalFallbackTreatment: &FallbackTreatment{
1314
Treatment: "global_treatment",
14-
Config: "global_config",
1515
},
1616
byFlagFallbackTreatment: map[string]FallbackTreatment{
1717
"flag1": {
1818
Treatment: "flag1_treatment",
19-
Config: "flag1_config",
19+
Config: &stringConfig,
2020
},
2121
},
2222
}
@@ -26,38 +26,38 @@ func TestFallbackTreatmentCalculatorResolve(t *testing.T) {
2626
label := "some_label"
2727
result := calc.Resolve("flag1", &label)
2828
assert.Equal(t, "flag1_treatment", result.Treatment)
29-
assert.Equal(t, "flag1_config", result.Config)
29+
assert.Equal(t, &stringConfig, result.Config)
3030
assert.Equal(t, "fallback - some_label", *result.Label)
3131

3232
// Test fallback to global treatment when flag not found
3333
result = calc.Resolve("flag2", &label)
3434
assert.Equal(t, "global_treatment", result.Treatment)
35-
assert.Equal(t, "global_config", result.Config)
35+
assert.Nil(t, result.Config)
3636
assert.Equal(t, "fallback - some_label", *result.Label)
3737

3838
// Test nil label handling
3939
result = calc.Resolve("flag1", nil)
4040
assert.Equal(t, "flag1_treatment", result.Treatment)
41-
assert.Equal(t, "flag1_config", result.Config)
41+
assert.Equal(t, &stringConfig, result.Config)
4242
assert.Nil(t, result.Label)
4343

4444
// Test default control when no config
4545
calcNoConfig := NewFallbackTreatmentCalculatorImp(nil)
4646
result = calcNoConfig.Resolve("flag1", &label)
4747
assert.Equal(t, "control", result.Treatment)
48-
assert.Equal(t, "", result.Config)
48+
assert.Nil(t, result.Config)
4949
assert.Equal(t, "some_label", *result.Label)
5050

5151
// Test global treatment when no flag-specific treatments exist
5252
configGlobalOnly := &FallbackTreatmentConfig{
5353
GlobalFallbackTreatment: &FallbackTreatment{
5454
Treatment: "global_treatment",
55-
Config: "global_config",
55+
Config: nil,
5656
},
5757
}
5858
calcGlobalOnly := NewFallbackTreatmentCalculatorImp(configGlobalOnly)
5959
result = calcGlobalOnly.Resolve("any_flag", &label)
6060
assert.Equal(t, "global_treatment", result.Treatment)
61-
assert.Equal(t, "global_config", result.Config)
61+
assert.Nil(t, result.Config)
6262
assert.Equal(t, "fallback - some_label", *result.Label)
63-
}
63+
}

0 commit comments

Comments
 (0)