Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions splitio_platform_interface/lib/split_result.dart
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@ class SplitResult {
String toString() {
return '{"treatment": "' +
treatment +
'", config: "' +
(config ?? 'null') +
'"}';
'", config: ' +
(config != null ? '"$config"' : 'null') +
'}';
}
}
13 changes: 10 additions & 3 deletions splitio_platform_interface/lib/split_view.dart
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,12 @@ class SplitView {
List<String> treatments = [];
int changeNumber;
Map<String, String> configs = {};
String defaultTreatment;
List<String> sets = [];

SplitView(this.name, this.trafficType, this.killed, this.treatments,
this.changeNumber, this.configs);
this.changeNumber, this.configs,
[this.defaultTreatment = '', this.sets = const []]);

static SplitView? fromEntry(Map<dynamic, dynamic>? entry) {
if (entry == null || entry.isEmpty) {
Expand All @@ -27,7 +30,9 @@ class SplitView {
entry['killed'],
(entry['treatments'] as List).map((el) => el as String).toList(),
entry['changeNumber'],
mappedConfig);
mappedConfig,
entry['defaultTreatment'] ?? '',
entry['sets'] ?? []);
}

@override
Expand All @@ -38,7 +43,9 @@ class SplitView {
killed: $killed,
treatments: ${treatments.toString()},
changeNumber: $changeNumber,
config: $configs
config: $configs,
defaultTreatment: $defaultTreatment,
sets: ${sets.toString()}
}''';
}
}
20 changes: 20 additions & 0 deletions splitio_platform_interface/test/split_result_test.dart
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
import 'package:flutter_test/flutter_test.dart';
import 'package:splitio_platform_interface/split_result.dart';

void main() {
test('result with config', () {
const result = SplitResult('on', 'config');

expect(result.treatment, 'on');
expect(result.config, 'config');
expect(result.toString(), '{"treatment": "on", config: "config"}');
});

test('result with null config', () {
const result = SplitResult('on', null);

expect(result.treatment, 'on');
expect(result.config, null);
expect(result.toString(), '{"treatment": "on", config: null}');
});
}
4 changes: 4 additions & 0 deletions splitio_platform_interface/test/split_view_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@ void main() {
'configs': {'yes': '{"abc"}', 'no': '"wasd"'},
'changeNumber': 156246,
'trafficType': 'default',
'defaultTreatment': 'on',
'sets': ['set1', 'set2'],
});

expect(splitView?.name, 'my_split');
Expand All @@ -30,5 +32,7 @@ void main() {
expect(splitView?.configs, {'yes': '{"abc"}', 'no': '"wasd"'});
expect(splitView?.changeNumber, 156246);
expect(splitView?.trafficType, 'default');
expect(splitView?.defaultTreatment, 'on');
expect(splitView?.sets, ['set1', 'set2']);
});
}