Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,18 +41,6 @@ jobs:
- name: Run Android test
run: cd splitio/example/android/; ./gradlew :splitio:testReleaseUnitTest;

build-ios:
name: Build iOS
runs-on: [ macos-latest ]

steps:
- uses: actions/[email protected]
- uses: subosito/[email protected]
with:
channel: 'stable'
- name: Run Build iOS
run: cd splitio/example/ios; flutter build ios --no-codesign;

test-ios:
name: Test iOS
runs-on: [ macos-latest ]
Expand Down
3 changes: 2 additions & 1 deletion splitio_platform_interface/lib/split_configuration.dart
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,8 @@ class SplitConfiguration {
if (syncConfig != null) {
configurationMap['syncConfig'] = {
'syncConfigNames': syncConfig.names.toList(growable: false),
'syncConfigPrefixes': syncConfig.prefixes.toList(growable: false)
'syncConfigPrefixes': syncConfig.prefixes.toList(growable: false),
'syncConfigFlagSets': syncConfig.sets.toList(growable: false)
};
}

Expand Down
10 changes: 10 additions & 0 deletions splitio_platform_interface/lib/split_sync_config.dart
Original file line number Diff line number Diff line change
@@ -1,20 +1,30 @@
class SyncConfig {
late Set<String> _names;
late Set<String> _prefixes;
late Set<String> _sets;

Set<String> get names => _names;

Set<String> get prefixes => _prefixes;

Set<String> get sets => _sets;

SyncConfig(
{List<String> names = const [], List<String> prefixes = const []}) {
_names = names.toSet();
_prefixes = prefixes.toSet();
_sets = <String>{};
}

SyncConfig.fromSet(
{Set<String> names = const {}, Set<String> prefixes = const {}}) {
_names = names;
_prefixes = prefixes;
}

SyncConfig.flagSets(List<String> sets) {
_sets = sets.toSet();
_names = <String>{};
_prefixes = <String>{};
}
}
20 changes: 20 additions & 0 deletions splitio_platform_interface/test/split_sync_config_test.dart
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
import 'package:flutter_test/flutter_test.dart';
import 'package:splitio_platform_interface/split_sync_config.dart';

void main() {
test('names and prefixes can be added simultaneously', () {
var syncConfig = SyncConfig(names: ['name1'], prefixes: ['prefix1']);

expect(syncConfig.names, ['name1']);
expect(syncConfig.prefixes, ['prefix1']);
expect(syncConfig.sets, []);
});

test('flagSets constructor allows only sets', () {
var syncConfig = SyncConfig.flagSets(['set1','set2']);

expect(syncConfig.names, []);
expect(syncConfig.prefixes, []);
expect(syncConfig.sets, ['set1','set2']);
});
}
15 changes: 13 additions & 2 deletions splitio_platform_interface/test/splitio_configuration_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import 'package:splitio_platform_interface/split_configuration.dart';
import 'package:splitio_platform_interface/split_sync_config.dart';

void main() {
test('valuesAreMappedCorrectly', () async {
test('values are mapped correctly', () async {
final SplitConfiguration config = SplitConfiguration(
eventFlushInterval: 2000,
eventsPerPush: 300,
Expand Down Expand Up @@ -65,10 +65,21 @@ void main() {
expect(config.configurationMap['readyTimeout'], 1);
});

test('noSpecialValuesLeavesMapEmpty', () async {
test('no special values leaves map empty', () async {
final SplitConfiguration config = SplitConfiguration();

expect(config.configurationMap.length, 1);
expect(config.configurationMap['readyTimeout'], 10);
});

test('sets values are mapped correctly', () async {
final SplitConfiguration config = SplitConfiguration(
syncConfig: SyncConfig.flagSets(['one', 'two']),
);

expect(config.configurationMap['syncConfig']['syncConfigNames'], []);
expect(config.configurationMap['syncConfig']['syncConfigPrefixes'], []);
expect(config.configurationMap['syncConfig']['syncConfigFlagSets'],
['one', 'two']);
});
}