Skip to content

Commit 04bd924

Browse files
authored
Fixes in pinning configuration (#129)
2 parents 7ff8039 + fe9f6c0 commit 04bd924

File tree

5 files changed

+13
-12
lines changed

5 files changed

+13
-12
lines changed

splitio/lib/splitio.dart

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ export 'package:splitio_platform_interface/split_impression.dart';
99
export 'package:splitio_platform_interface/split_result.dart';
1010
export 'package:splitio_platform_interface/split_sync_config.dart';
1111
export 'package:splitio_platform_interface/split_view.dart';
12+
export 'package:splitio_platform_interface/split_certificate_pinning_configuration.dart';
1213

1314
typedef ClientReadinessCallback = void Function(SplitClient splitClient);
1415

splitio_platform_interface/lib/certificate_pinning_configuration.dart renamed to splitio_platform_interface/lib/split_certificate_pinning_configuration.dart

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
class CertificatePinningConfiguration {
22

3-
final Map<String, Set<String>> _pins = {};
3+
final Map<String, List<String>> _pins = {};
44

5-
Map<String, Set<String>> get pins => _pins;
5+
Map<String, List<String>> get pins => _pins;
66

77
CertificatePinningConfiguration addPin(String host, String pin) {
88
pin = pin.trim();
@@ -11,7 +11,7 @@ class CertificatePinningConfiguration {
1111
}
1212

1313
if (!_pins.containsKey(host)) {
14-
_pins[host] = <String>{};
14+
_pins[host] = [];
1515
}
1616

1717
_pins[host]?.add(pin);

splitio_platform_interface/lib/split_configuration.dart

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import 'package:splitio_platform_interface/certificate_pinning_configuration.dart';
1+
import 'package:splitio_platform_interface/split_certificate_pinning_configuration.dart';
22
import 'package:splitio_platform_interface/split_sync_config.dart';
33

44
class SplitConfiguration {
@@ -46,7 +46,7 @@ class SplitConfiguration {
4646
///
4747
/// [readyTimeout] Maximum amount of time in seconds to wait before firing the SDK_READY_TIMED_OUT event. Defaults to 10 seconds.
4848
///
49-
/// [certificatePinningConfig] Certificate pinning configuration. It is a map where the key is the host and the value is a set of base64 SHA-256 or base64 SHA-1 hashes of the SPKI.
49+
/// [certificatePinningConfiguration] Certificate pinning configuration. It is a map where the key is the host and the value is a set of base64 SHA-256 or base64 SHA-1 hashes of the SPKI.
5050
SplitConfiguration({
5151
int? featuresRefreshRate,
5252
int? segmentsRefreshRate,
@@ -73,7 +73,7 @@ class SplitConfiguration {
7373
bool? encryptionEnabled,
7474
SplitLogLevel? logLevel,
7575
int? readyTimeout = 10,
76-
CertificatePinningConfiguration? certificatePinningConfig,
76+
CertificatePinningConfiguration? certificatePinningConfiguration,
7777
}) {
7878
if (featuresRefreshRate != null) {
7979
configurationMap['featuresRefreshRate'] = featuresRefreshRate;
@@ -180,10 +180,10 @@ class SplitConfiguration {
180180
configurationMap['readyTimeout'] = readyTimeout;
181181
}
182182

183-
if (certificatePinningConfig != null &&
184-
certificatePinningConfig.pins.isNotEmpty) {
183+
if (certificatePinningConfiguration != null &&
184+
certificatePinningConfiguration.pins.isNotEmpty) {
185185
configurationMap['certificatePinningConfiguration'] = {
186-
'pins': certificatePinningConfig.pins
186+
'pins': certificatePinningConfiguration.pins
187187
};
188188
}
189189
}

splitio_platform_interface/test/certificate_pinning_configuration_test.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import 'package:flutter_test/flutter_test.dart';
2-
import 'package:splitio_platform_interface/certificate_pinning_configuration.dart';
2+
import 'package:splitio_platform_interface/split_certificate_pinning_configuration.dart';
33

44
void main() {
55
test('single pin can be added', () {

splitio_platform_interface/test/splitio_configuration_test.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import 'package:flutter_test/flutter_test.dart';
2-
import 'package:splitio_platform_interface/certificate_pinning_configuration.dart';
2+
import 'package:splitio_platform_interface/split_certificate_pinning_configuration.dart';
33
import 'package:splitio_platform_interface/split_configuration.dart';
44
import 'package:splitio_platform_interface/split_sync_config.dart';
55

@@ -31,7 +31,7 @@ void main() {
3131
encryptionEnabled: true,
3232
logLevel: SplitLogLevel.debug,
3333
readyTimeout: 1,
34-
certificatePinningConfig: CertificatePinningConfiguration()
34+
certificatePinningConfiguration: CertificatePinningConfiguration()
3535
.addPin('host1', 'pin1')
3636
.addPin('host2', 'pin3')
3737
.addPin('host1', 'pin2'));

0 commit comments

Comments
 (0)