Skip to content

Commit 010ecdc

Browse files
committed
Tests for platform interface (#47)
1 parent e0a2e27 commit 010ecdc

14 files changed

+1167
-562
lines changed

splitio/lib/split_client.dart

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
import 'package:flutter/foundation.dart';
21
import 'package:splitio_platform_interface/split_result.dart';
32
import 'package:splitio_platform_interface/splitio_platform_interface.dart';
43

@@ -146,10 +145,6 @@ class DefaultSplitClient implements SplitClient {
146145

147146
DefaultSplitClient(this._platform, this._matchingKey, this._bucketingKey);
148147

149-
@visibleForTesting
150-
DefaultSplitClient.withEventListener(
151-
this._platform, this._matchingKey, this._bucketingKey);
152-
153148
@override
154149
Future<String> getTreatment(String splitName,
155150
[Map<String, dynamic> attributes = const {}]) async {

splitio/lib/splitio.dart

Lines changed: 5 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,9 @@ class Splitio {
1818

1919
final String _defaultMatchingKey;
2020

21-
late final String? _defaultBucketingKey;
21+
late String? _defaultBucketingKey;
2222

23-
late final SplitConfiguration? _splitConfiguration;
23+
late SplitConfiguration? _splitConfiguration;
2424

2525
final SplitioPlatform _platform = SplitioPlatform.instance;
2626

@@ -103,15 +103,13 @@ class Splitio {
103103
}
104104

105105
Future<List<String>> splitNames() async {
106-
List<String> splitNames = await _platform.splitNames(
107-
matchingKey: _defaultMatchingKey, bucketingKey: _defaultBucketingKey);
106+
List<String> splitNames = await _platform.splitNames();
108107

109108
return splitNames;
110109
}
111110

112111
Future<List<SplitView>> splits() async {
113-
return _platform.splits(
114-
matchingKey: _defaultMatchingKey, bucketingKey: _defaultBucketingKey);
112+
return _platform.splits();
115113
}
116114

117115
/// If the impressionListener configuration has been enabled,
@@ -121,10 +119,7 @@ class Splitio {
121119
}
122120

123121
Future<SplitView?> split(String splitName) async {
124-
return _platform.split(
125-
matchingKey: _defaultMatchingKey,
126-
bucketingKey: _defaultBucketingKey,
127-
splitName: splitName);
122+
return _platform.split(splitName: splitName);
128123
}
129124

130125
Future<void> _init() {

0 commit comments

Comments
 (0)