Allow deleting dependent resources when they have not yet been created

[grantfitzsimmons]

Our users are using the clone and carry-forward options when creating a group of similar specimens into the system. They often need to delete a preparation or a few of the collection object property traits with each new specimen. However we haven't given these users any "delete" permissions as part of their roles.

Would it be possible for Specify to ignore the delete permissions when a specimen (or any new object) has yet to be saved and added to the database? It would make things a lot easier, and there is no danger of deleting anything that has been registered. Of course once they click save their role permission needs to activate again!

Requested by: CSIRO on Asana

[maxpatiiuk]

hmm, I though we were already doing this, but maybe not as an oversight

we already have the logic for checking for "create" permission for new resources but "edit" for existing ones:

specify7/specifyweb/frontend/js_src/lib/components/Forms/ResourceView.tsx

Lines 81 to 88 in a0b59e3

	export const augmentMode = (
	isReadOnly: boolean,
	isNew: boolean,
	tableName: keyof Tables | undefined
	): boolean =>
	isReadOnly ||
	tableName === undefined ||
	!hasTablePermission(tableName, isNew ? 'create' : 'update');

would look something similar, but for delete

Related, but removing independent resource doesn't require delete permission as rather than deleting the independent resource, it simply removes the reference to it:

specify7/specifyweb/frontend/js_src/lib/components/FormSliders/IntegratedRecordSelector.tsx

Lines 171 to 184 in a0b59e3

	{hasTablePermission(
	relationship.relatedTable.name,
	isDependent ? 'delete' : 'read'
	) && typeof handleRemove === 'function' ? (
	<DataEntry.Remove
	disabled={
	isReadOnly ||
	collection.models.length === 0 ||
	resource === undefined
	}
	onClick={(): void => {
	handleRemove('minusButton');
	}}
	/>

[grantfitzsimmons]

Mentioned as a big QOL improvement if we can resolve soon

[maxpatiiuk]

This might be a 5 line PR (excluding testing)

[zoewarner1]

Hi @grantfitzsimmons - just wondering if there was an update on this? It has come up again from a user and likely to have more users using the clone function soon too. Not being able to delete dependent resources that aren't needed is a bit of a sticking point. Thanks!

[grantfitzsimmons]

@maxpatiiuk Can you tell us which 5 lines?

[maxpatiiuk]

I think this is the relevant line:

specify7/specifyweb/frontend/js_src/lib/components/FormSliders/IntegratedRecordSelector.tsx

Lines 308 to 311 in f292f99

	{hasTablePermission(
	relationship.relatedTable.name,
	isDependent ? 'delete' : 'read'
	) && typeof handleRemove === 'function' ? (

For existing resources, check for "delete" permission like it does right now. But for not-yet-saved resources, the "read" should be sufficient (don't need to check for "create" as that is already assumed by the fact the user was able to add a new not-yet-saved resource)