resolve readonly assignment errors in global preferences utils and loader

Author: Gitesh307

specifyweb/frontend/js_src/lib/components/Preferences/globalPreferencesLoader.ts

@@ -31,30 +31,41 @@ function mergeMissingFromRemote(
 
   const remoteFormatting = remote.formatting?.formatting;
   if (remoteFormatting !== undefined) {
-    const currentFormatting = existing.formatting?.formatting ?? {};
-    const updatedFormatting: Partial<GlobalPreferenceValues['formatting']['formatting']> = {
-      ...currentFormatting,
+    const currentFormatting = existing.formatting?.formatting;
+    const updatedFormatting: Record<
+      keyof GlobalPreferenceValues['formatting']['formatting'],
+      string | undefined
+    > = {
+      fullDateFormat: currentFormatting?.fullDateFormat,
+      monthYearDateFormat: currentFormatting?.monthYearDateFormat,
     };
 
     (['fullDateFormat', 'monthYearDateFormat'] as const).forEach((key) => {
       const remoteValue = remoteFormatting[key];
       if (
         remoteValue !== undefined &&
-        updatedFormatting[key] === undefined &&
+        (updatedFormatting[key] ?? undefined) === undefined &&
         remoteValue !== DEFAULT_VALUES.formatting.formatting[key]
       ) {
         updatedFormatting[key] = remoteValue;
         changed = true;
       }
     });
 
-    if (changed)
+    if (changed) {
+      const formattingPayload: Record<string, unknown> = {};
+      if (updatedFormatting.fullDateFormat !== undefined)
+        formattingPayload.fullDateFormat = updatedFormatting.fullDateFormat;
+      if (updatedFormatting.monthYearDateFormat !== undefined)
+        formattingPayload.monthYearDateFormat = updatedFormatting.monthYearDateFormat;
+
       merged = {
         ...merged,
         formatting: {
-          formatting: updatedFormatting as GlobalPreferenceValues['formatting']['formatting'],
+          formatting: formattingPayload as GlobalPreferenceValues['formatting']['formatting'],
         },
       };
+    }
   }
 
   return { merged, changed };

specifyweb/frontend/js_src/lib/components/Preferences/globalPreferencesUtils.ts

@@ -111,26 +111,26 @@ function hasProperties<T extends Record<string, unknown>>(object: T): object is
 export function partialPreferencesFromMap(
   map: Readonly<Record<string, string>>
 ): Partial<GlobalPreferenceValues> {
-  const partial: Partial<GlobalPreferenceValues> = {};
+  const partial: Record<string, unknown> = {};
 
-  const auditing: Partial<GlobalPreferenceValues['auditing']['auditing']> = {};
+  const auditingValues: Record<string, unknown> = {};
   const enableAuditLog = parseBoolean(map[PREFERENCE_KEYS.enableAuditLog]);
-  if (enableAuditLog !== undefined) auditing.enableAuditLog = enableAuditLog;
+  if (enableAuditLog !== undefined) auditingValues.enableAuditLog = enableAuditLog;
 
   const logFieldLevelChanges = parseBoolean(map[PREFERENCE_KEYS.logFieldLevelChanges]);
   if (logFieldLevelChanges !== undefined)
-    auditing.logFieldLevelChanges = logFieldLevelChanges;
+    auditingValues.logFieldLevelChanges = logFieldLevelChanges;
 
-  if (hasProperties(auditing)) {
+  if (hasProperties(auditingValues)) {
     partial.auditing = {
-      auditing: auditing as GlobalPreferenceValues['auditing']['auditing'],
+      auditing: auditingValues,
     };
   }
 
-  const formatting: Partial<GlobalPreferenceValues['formatting']['formatting']> = {};
+  const formattingValues: Record<string, unknown> = {};
   const fullDateFormatRaw = map[PREFERENCE_KEYS.fullDateFormat];
   if (fullDateFormatRaw !== undefined)
-    formatting.fullDateFormat = normalizeFormat(fullDateFormatRaw);
+    formattingValues.fullDateFormat = normalizeFormat(fullDateFormatRaw);
 
   const monthYearDateFormatRaw = map[PREFERENCE_KEYS.monthYearDateFormat];
   if (monthYearDateFormatRaw !== undefined) {
@@ -140,29 +140,29 @@ export function partialPreferencesFromMap(
         monthYearFormat as (typeof MONTH_YEAR_FORMAT_OPTIONS)[number]
       )
     )
-      formatting.monthYearDateFormat = monthYearFormat;
+      formattingValues.monthYearDateFormat = monthYearFormat;
   }
 
-  if (hasProperties(formatting)) {
+  if (hasProperties(formattingValues)) {
     partial.formatting = {
-      formatting: formatting as GlobalPreferenceValues['formatting']['formatting'],
+      formatting: formattingValues,
     };
   }
 
-  const attachments: Partial<GlobalPreferenceValues['attachments']['attachments']> = {};
+  const attachmentValues: Record<string, unknown> = {};
   const attachmentThumbnailSize = parseNumber(
     map[PREFERENCE_KEYS.attachmentThumbnailSize]
   );
   if (attachmentThumbnailSize !== undefined)
-    attachments.attachmentThumbnailSize = attachmentThumbnailSize;
+    attachmentValues.attachmentThumbnailSize = attachmentThumbnailSize;
 
-  if (hasProperties(attachments)) {
+  if (hasProperties(attachmentValues)) {
     partial.attachments = {
-      attachments: attachments as GlobalPreferenceValues['attachments']['attachments'],
+      attachments: attachmentValues,
     };
   }
 
-  return partial;
+  return partial as Partial<GlobalPreferenceValues>;
 }
 
 export function mergeWithDefaultValues(