remove automatic pinMode in digitalWrite

oclyke · oclyke · commit 11c110eb45b0 · 2020-04-15T14:47:55.000-06:00
leaving the ap3_get_funct_sel function for future utility
diff --git a/cores/arduino/ard_sup/gpio/ap3_gpio.cpp b/cores/arduino/ard_sup/gpio/ap3_gpio.cpp
@@ -35,7 +35,6 @@ static inline uint32_t ap3_get_funct_sel(ap3_gpio_pad_t pad);
 //Additional Defines
 #define PADREG_FNSEL_Msk 0x38
 #define GPIO_FUNCTION 3
-#
 
 ap3_gpio_pad_t ap3_gpio_pin2pad(ap3_gpio_pin_t pin)
 {
@@ -137,10 +136,6 @@ extern void digitalWrite(uint8_t pin, uint8_t val)
     {
         return;
     }
-    if (ap3_get_funct_sel(pad) != GPIO_FUNCTION)
-    {
-        pinMode(pin, OUTPUT);
-    }
     if (val)
     {
         am_hal_gpio_output_set(ap3_gpio_pin2pad(pin));

Original file line number	Diff line number	Diff line change
`@@ -35,7 +35,6 @@ static inline uint32_t ap3_get_funct_sel(ap3_gpio_pad_t pad);`
`35`	`35`	`//Additional Defines`
`36`	`36`	`#define PADREG_FNSEL_Msk 0x38`
`37`	`37`	`#define GPIO_FUNCTION 3`
`38`		`-#`
`39`	`38`
`40`	`39`	`ap3_gpio_pad_t ap3_gpio_pin2pad(ap3_gpio_pin_t pin)`
`41`	`40`	`{`
`@@ -137,10 +136,6 @@ extern void digitalWrite(uint8_t pin, uint8_t val)`
`137`	`136`	`{`
`138`	`137`	`return;`
`139`	`138`	`}`
`140`		`- if (ap3_get_funct_sel(pad) != GPIO_FUNCTION)`
`141`		`- {`
`142`		`- pinMode(pin, OUTPUT);`
`143`		`- }`
`144`	`139`	`if (val)`
`145`	`140`	`{`
`146`	`141`	`am_hal_gpio_output_set(ap3_gpio_pin2pad(pin));`