From fa2ac5182769d962ad1fa5526f9e190a88b170b9 Mon Sep 17 00:00:00 2001 From: Damian Rouson Date: Wed, 9 Aug 2017 11:12:38 -0700 Subject: [PATCH 1/2] Bolster test requirements in PR template --- .github/PULL_REQUEST_TEMPLATE.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index e8d5af4ad..125fb8a8d 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -45,7 +45,8 @@ This pull request (PR) is a: be introduced) - Commenting code where it is non-obvious and non-trivial - Running tests locally, to ensure all of them pass - - Maintaining or increasing test coverage + - Increasing test coverage for all bug-fix or feature-addition pull + requests and at least maintaining test converage for all others. - Logically atomic, self consistent and coherent commits - Commit message content - Waiting 24 hours before self-approving the pull request to From 391be7bac6f5263c594bf7e5b034986f90c03785 Mon Sep 17 00:00:00 2001 From: Damian Rouson Date: Wed, 9 Aug 2017 11:34:59 -0700 Subject: [PATCH 2/2] Overall tightening of pull request template --- .github/PULL_REQUEST_TEMPLATE.md | 21 ++++++++++----------- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 125fb8a8d..443d2a3d6 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -36,19 +36,18 @@ This pull request (PR) is a: ### I certify that ### -- [ ] I have reviewed the [contributing guidelines] and followed the - policies on: - - Pull request (PR) naming to indicate work in progress (WIP), - and to attach the PR to the appropriate bug report, or feature - request [issue] +- [ ] I reviewed and followed the [contributing guidelines], including + - Increasing test coverage for all feature-addition PRs + - Increasing test coverage for all bug-fix PRs for which there + does not already exist a related test that failed before the PR + - At least maintaining test coverage for all other PRs + - Ensuring that all tests pass when run locally + - Naming PR to indicate work in progress (WIP) and to attach the PR + to the appropriate bug report or feature request [issue] - White space (no trailing white space or white space errors may be introduced) - Commenting code where it is non-obvious and non-trivial - - Running tests locally, to ensure all of them pass - - Increasing test coverage for all bug-fix or feature-addition pull - requests and at least maintaining test converage for all others. - Logically atomic, self consistent and coherent commits - Commit message content - - Waiting 24 hours before self-approving the pull request to - give another OpenCoarrays developer a chance to review my - proposed code + - Waiting 24 hours before self-approving the PR to give another + OpenCoarrays developer a chance to review my proposed code