Fix constructorless classes

Author: SuperAuguste

snapshots/input/syntax/src/constructor.ts

@@ -25,3 +25,11 @@ export function useConstructor2(): SuperConstructor2 {
 export function useConstructor3(): Yay.Woo.MyClass {
   return new Yay.Woo.MyClass()
 }
+
+export class NoConstructor {
+  property: number
+}
+
+export function useNoConstructor() {
+  return new NoConstructor()
+}

snapshots/output/pnpm-workspaces/packages/b/src/b.ts

@@ -1,12 +1,13 @@
   import { a } from '@example/a'
 // definition @example/b 1.0.0 src/`b.ts`/
 //documentation ```ts\nmodule "b.ts"\n```
-//         ^ reference local 0
+//         ^ reference @example/a 1.0.0 src/`a.ts`/a().
+//                  ^^^^^^^^^^^^ reference @example/a 1.0.0 src/`a.ts`/
 
   export function b() {
 //                ^ definition @example/b 1.0.0 src/`b.ts`/b().
-//                documentation ```ts\nfunction b(): any\n```
+//                documentation ```ts\nfunction b(): string\n```
     return a()
-//         ^ reference local 0
+//         ^ reference @example/a 1.0.0 src/`a.ts`/a().
   }
 

snapshots/output/syntax/src/accessors.ts

@@ -97,7 +97,7 @@
     const c = new C()
 //        ^ definition local 2
 //        documentation ```ts\nvar c: C\n```
-//                ^ reference syntax 1.0.0 src/`accessors.ts`/C#`<constructor>`().
+//                ^ reference syntax 1.0.0 src/`accessors.ts`/C#
     c.length = 10
 //  ^ reference local 2
 //    ^^^^^^ reference syntax 1.0.0 src/`accessors.ts`/C#`<get>length`().
@@ -120,7 +120,7 @@
     const d = new D()
 //        ^ definition local 5
 //        documentation ```ts\nvar d: D\n```
-//                ^ reference syntax 1.0.0 src/`accessors.ts`/D#`<constructor>`().
+//                ^ reference syntax 1.0.0 src/`accessors.ts`/D#
     d.length = 0
 //  ^ reference local 5
 //    ^^^^^^ reference syntax 1.0.0 src/`accessors.ts`/D#`<get>length`().

snapshots/output/syntax/src/constructor.ts

@@ -66,3 +66,18 @@
 //                     ^^^^^^^ reference syntax 1.0.0 src/`constructor.ts`/Yay/Woo/MyClass#`<constructor>`().
   }
 
+  export class NoConstructor {
+//             ^^^^^^^^^^^^^ definition syntax 1.0.0 src/`constructor.ts`/NoConstructor#
+//             documentation ```ts\nclass NoConstructor\n```
+    property: number
+//  ^^^^^^^^ definition syntax 1.0.0 src/`constructor.ts`/NoConstructor#property.
+//  documentation ```ts\n(property) property: number\n```
+  }
+  
+  export function useNoConstructor() {
+//                ^^^^^^^^^^^^^^^^ definition syntax 1.0.0 src/`constructor.ts`/useNoConstructor().
+//                documentation ```ts\nfunction useNoConstructor(): NoConstructor\n```
+    return new NoConstructor()
+//             ^^^^^^^^^^^^^ reference syntax 1.0.0 src/`constructor.ts`/NoConstructor#
+  }
+  

snapshots/output/syntax/src/type-alias.ts

@@ -28,7 +28,7 @@
 //      ^^ definition syntax 1.0.0 src/`type-alias.ts`/cs.
 //      documentation ```ts\nvar cs: Cstring\n```
 //          ^^^^^^^ reference syntax 1.0.0 src/`type-alias.ts`/Cstring#
-//                        ^ reference syntax 1.0.0 src/`type-alias.ts`/C#`<constructor>`().
+//                        ^ reference syntax 1.0.0 src/`type-alias.ts`/C#
 
   class D<T, U> {
 //      ^ definition syntax 1.0.0 src/`type-alias.ts`/D#
@@ -66,10 +66,10 @@
 //      ^^ definition syntax 1.0.0 src/`type-alias.ts`/dt.
 //      documentation ```ts\nvar dt: DT<string>\n```
 //          ^^ reference syntax 1.0.0 src/`type-alias.ts`/DT#
-//                           ^ reference syntax 1.0.0 src/`type-alias.ts`/D#`<constructor>`().
+//                           ^ reference syntax 1.0.0 src/`type-alias.ts`/D#
   const du: DU<string> = new D()
 //      ^^ definition syntax 1.0.0 src/`type-alias.ts`/du.
 //      documentation ```ts\nvar du: DU<string>\n```
 //          ^^ reference syntax 1.0.0 src/`type-alias.ts`/DU#
-//                           ^ reference syntax 1.0.0 src/`type-alias.ts`/D#`<constructor>`().
+//                           ^ reference syntax 1.0.0 src/`type-alias.ts`/D#
 

src/FileIndexer.ts

@@ -31,6 +31,7 @@ export class FileIndexer {
     public readonly input: Input,
     public readonly document: scip.scip.Document,
     public readonly globalSymbolTable: Map<ts.Node, ScipSymbol>,
+    public readonly globalConstructorTable: Map<ts.ClassDeclaration, boolean>,
     public readonly packages: Packages,
     public readonly sourceFile: ts.SourceFile
   ) {
@@ -110,6 +111,21 @@ export class FileIndexer {
     return symbol
   }
 
+  private hasConstructor(classDeclaration: ts.ClassDeclaration): boolean {
+    const cached = this.globalConstructorTable.get(classDeclaration)
+    if (cached !== undefined) return cached
+
+    for (const member of classDeclaration.members) {
+      if (ts.isConstructorDeclaration(member)) {
+        this.globalConstructorTable.set(classDeclaration, true)
+        return true
+      }
+    }
+
+    this.globalConstructorTable.set(classDeclaration, false)
+    return false
+  }
+
   private visitSymbolOccurrence(node: ts.Node, sym: ts.Symbol): void {
     const range = Range.fromNode(node).toLsif()
     let role = 0
@@ -136,7 +152,8 @@ export class FileIndexer {
         ((ts.isIdentifier(node) && ts.isNewExpression(node.parent)) ||
           (ts.isPropertyAccessExpression(node.parent) &&
             ts.isNewExpression(node.parent.parent))) &&
-        ts.isClassDeclaration(declaration)
+        ts.isClassDeclaration(declaration) &&
+        this.hasConstructor(declaration)
       ) {
         scipSymbol = ScipSymbol.global(
           scipSymbol,

src/ProjectIndexer.ts

@@ -72,6 +72,7 @@ export class ProjectIndexer {
   private program: ts.Program
   private checker: ts.TypeChecker
   private symbolCache: Map<ts.Node, ScipSymbol> = new Map()
+  private hasConstructor: Map<ts.ClassDeclaration, boolean> = new Map()
   private packages: Packages
   constructor(
     public readonly config: ts.ParsedCommandLine,
@@ -140,6 +141,7 @@ export class ProjectIndexer {
         input,
         document,
         this.symbolCache,
+        this.hasConstructor,
         this.packages,
         sourceFile
       )