feat: Improve default search mode robustness and error handling

  Address CodeRabbit review feedback to enhance production readiness:

  - Add runtime validation with Zod schema for mode parameter in server actions
  - Enhance audit logging with before/after values for better change tracking
  - Fix homepage logic to clamp org default and cookie values when no language models available
  - Improve error handling to surface specific ServiceError messages in toast notifications
  - Hide default search mode card for non-owners instead of just disabling it
  - Add searchModeSchema export to types for reusable validation

  Prevents invalid states where "Ask" mode could be set/used without configured models
  and provides clearer feedback to users when operations fail.

Author: shohamd4

packages/web/src/actions.ts

@@ -40,6 +40,7 @@ import { getAuditService } from "@/ee/features/audit/factory";
 import { addUserToOrganization, orgHasAvailability } from "@/lib/authUtils";
 import { getOrgMetadata } from "@/lib/utils";
 import { getOrgFromDomain } from "./data/org";
+import { searchModeSchema } from "@/types";
 
 const ajv = new Ajv({
     validateFormats: false,
@@ -2189,10 +2190,21 @@ export const getDefaultSearchMode = async (domain: string): Promise<"precise" |
 });
 
 export const setDefaultSearchMode = async (domain: string, mode: "precise" | "agentic"): Promise<{ success: boolean } | ServiceError> => sew(async () => {
+    // Runtime validation to guard server action from invalid input
+    const parsed = searchModeSchema.safeParse(mode);
+    if (!parsed.success) {
+        return {
+            statusCode: StatusCodes.BAD_REQUEST,
+            errorCode: ErrorCode.INVALID_REQUEST_BODY,
+            message: "Invalid default search mode",
+        } satisfies ServiceError;
+    }
+    const validatedMode = parsed.data;
+
     return await withAuth(async (userId) => {
         return await withOrgMembership(userId, domain, async ({ org }) => {
             // Validate that agentic mode is not being set when no language models are configured
-            if (mode === "agentic") {
+            if (validatedMode === "agentic") {
                 const { getConfiguredLanguageModelsInfo } = await import("@/features/chat/actions");
                 const languageModels = await getConfiguredLanguageModelsInfo();
                 if (languageModels.length === 0) {
@@ -2205,9 +2217,10 @@ export const setDefaultSearchMode = async (domain: string, mode: "precise" | "ag
             }
 
             const currentMetadata = getOrgMetadata(org);
+            const previousMode = currentMetadata?.defaultSearchMode ?? "precise";
             const mergedMetadata = {
                 ...(currentMetadata ?? {}),
-                defaultSearchMode: mode,
+                defaultSearchMode: validatedMode,
             };
 
             await prisma.org.update({
@@ -2231,7 +2244,8 @@ export const setDefaultSearchMode = async (domain: string, mode: "precise" | "ag
                 },
                 orgId: org.id,
                 metadata: {
-                    defaultSearchMode: mode
+                    previousDefaultSearchMode: previousMode,
+                    newDefaultSearchMode: validatedMode
                 }
             });
 

packages/web/src/app/[domain]/page.tsx

@@ -52,14 +52,17 @@ export default async function Home(props: { params: Promise<{ domain: string }>
     const defaultSearchMode = await getDefaultSearchMode(domain);
     // If there was an error or no setting found, default to precise (search)
     const orgDefaultMode = isServiceError(defaultSearchMode) ? "precise" : defaultSearchMode;
+    const effectiveOrgDefaultMode =
+        orgDefaultMode === "agentic" && models.length === 0 ? "precise" : orgDefaultMode;
 
     // Read search mode from cookie, defaulting to the org's default setting if not set
     const cookieStore = await cookies();
     const searchModeCookie = cookieStore.get(SEARCH_MODE_COOKIE_NAME);
     const initialSearchMode = (
         searchModeCookie?.value === "agentic" ||
         searchModeCookie?.value === "precise"
-    ) ? searchModeCookie.value : orgDefaultMode;
+    ) ? ((searchModeCookie.value === "agentic" && models.length === 0) ? "precise" : searchModeCookie.value)
+      : effectiveOrgDefaultMode;
 
     const isAgenticSearchTutorialDismissed = cookieStore.get(AGENTIC_SEARCH_TUTORIAL_DISMISSED_COOKIE_NAME)?.value === "true";
 

packages/web/src/app/[domain]/settings/(general)/components/defaultSearchModeCard.tsx

@@ -34,7 +34,19 @@ export const DefaultSearchModeCard = ({ initialDefaultMode, currentUserRole, isA
         setIsUpdating(true);
         try {
             const result = await setDefaultSearchMode(domain as string, defaultSearchMode);
-            if (!result || typeof result !== 'object' || !result.success) {
+            if (!result || typeof result !== 'object') {
+                throw new Error('Unexpected response');
+            }
+            // If this is a ServiceError, surface its message
+            if ('statusCode' in result && 'errorCode' in result && 'message' in result) {
+                toast({
+                    title: "Failed to update",
+                    description: result.message,
+                    variant: "destructive",
+                });
+                return;
+            }
+            if (!result.success) {
                 throw new Error('Failed to update default search mode');
             }
             toast({
@@ -44,11 +56,14 @@ export const DefaultSearchModeCard = ({ initialDefaultMode, currentUserRole, isA
             });
         } catch (error) {
             console.error('Error updating default search mode:', error);
-            toast({
-                title: "Failed to update",
-                description: "An error occurred while updating the default search mode.",
-                variant: "destructive",
-            });
+            // If we already showed a specific error above, do nothing here; otherwise fallback
+            if (!(error instanceof Error && /Unexpected response/.test(error.message))) {
+                toast({
+                    title: "Failed to update",
+                    description: "An error occurred while updating the default search mode.",
+                    variant: "destructive",
+                });
+            }
         } finally {
             setIsUpdating(false);
         }

packages/web/src/app/[domain]/settings/(general)/page.tsx

@@ -8,6 +8,7 @@ import { ServiceErrorException } from "@/lib/serviceError";
 import { ErrorCode } from "@/lib/errorCodes";
 import { headers } from "next/headers";
 import { getConfiguredLanguageModelsInfo } from "@/features/chat/actions";
+import { OrgRole } from "@sourcebot/db";
 
 interface GeneralSettingsPageProps {
     params: Promise<{
@@ -63,11 +64,13 @@ export default async function GeneralSettingsPage(props: GeneralSettingsPageProp
                 rootDomain={host}
             />
 
-            <DefaultSearchModeCard
-                initialDefaultMode={initialDefaultMode}
-                currentUserRole={currentUserRole}
-                isAskModeAvailable={isAskModeAvailable}
-            />
+            {currentUserRole === OrgRole.OWNER && (
+                <DefaultSearchModeCard
+                    initialDefaultMode={initialDefaultMode}
+                    currentUserRole={currentUserRole}
+                    isAskModeAvailable={isAskModeAvailable}
+                />
+            )}
         </div>
     )
 }

packages/web/src/types.ts

@@ -1,8 +1,10 @@
 import { z } from "zod";
 
+export const searchModeSchema = z.enum(["precise", "agentic"]);
+
 export const orgMetadataSchema = z.object({
     anonymousAccessEnabled: z.boolean().optional(),
-    defaultSearchMode: z.enum(["precise", "agentic"]).optional(),
+    defaultSearchMode: searchModeSchema.optional(),
 })
 
 export const demoSearchScopeSchema = z.object({