Connections UX pass + query optimizations (#212)

Author: brendan-kellam

packages/backend/src/connectionManager.ts

@@ -1,6 +1,6 @@
-import { Connection, ConnectionSyncStatus, PrismaClient, Prisma, Repo } from "@sourcebot/db";
+import { Connection, ConnectionSyncStatus, PrismaClient, Prisma } from "@sourcebot/db";
 import { Job, Queue, Worker } from 'bullmq';
-import { Settings, WithRequired } from "./types.js";
+import { Settings } from "./types.js";
 import { ConnectionConfig } from "@sourcebot/schemas/v3/connection.type";
 import { createLogger } from "./logger.js";
 import os from 'os';
@@ -24,7 +24,7 @@ type JobPayload = {
 };
 
 type JobResult = {
-    repoCount: number
+    repoCount: number,
 }
 
 export class ConnectionManager implements IConnectionManager {
@@ -82,7 +82,7 @@ export class ConnectionManager implements IConnectionManager {
         }, this.settings.resyncConnectionPollingIntervalMs);
     }
 
-    private async runSyncJob(job: Job<JobPayload>) {
+    private async runSyncJob(job: Job<JobPayload>): Promise<JobResult> {
         const { config, orgId } = job.data;
         // @note: We aren't actually doing anything with this atm.
         const abortController = new AbortController();
@@ -105,6 +105,7 @@ export class ConnectionManager implements IConnectionManager {
                 id: job.data.connectionId,
             },
             data: {
+                syncStatus: ConnectionSyncStatus.SYNCING,
                 syncStatusMetadata: {}
             }
         })
@@ -233,12 +234,25 @@ export class ConnectionManager implements IConnectionManager {
         this.logger.info(`Connection sync job ${job.id} completed`);
         const { connectionId } = job.data;
 
+        let syncStatusMetadata: Record<string, unknown> = (await this.db.connection.findUnique({
+            where: { id: connectionId },
+            select: { syncStatusMetadata: true }
+        }))?.syncStatusMetadata as Record<string, unknown> ?? {};
+        const { notFound } = syncStatusMetadata as { notFound: {
+            users: string[],
+            orgs: string[],
+            repos: string[],
+        }};
+
         await this.db.connection.update({
             where: {
                 id: connectionId,
             },
             data: {
-                syncStatus: ConnectionSyncStatus.SYNCED,
+                syncStatus:
+                    notFound.users.length > 0 ||
+                    notFound.orgs.length > 0 ||
+                    notFound.repos.length > 0 ? ConnectionSyncStatus.SYNCED_WITH_WARNINGS : ConnectionSyncStatus.SYNCED,
                 syncedAt: new Date()
             }
         })

packages/backend/src/gitea.ts

@@ -82,7 +82,7 @@ export const getGiteaReposFromConfig = async (config: GiteaConnectionConfig, org
             const tagGlobs = config.revisions.tags;
             allRepos = await Promise.all(
                 allRepos.map(async (allRepos) => {
-                    const [owner, name] = allRepos.name!.split('/');
+                    const [owner, name] = allRepos.full_name!.split('/');
                     let tags = (await fetchWithRetry(
                         () => getTagsForRepo(owner, name, api),
                         `tags for ${owner}/${name}`,

packages/backend/src/gitlab.ts

@@ -12,7 +12,6 @@ export const GITLAB_CLOUD_HOSTNAME = "gitlab.com";
 export const getGitLabReposFromConfig = async (config: GitlabConnectionConfig, orgId: number, db: PrismaClient) => {
     const tokenResult = config.token ? await getTokenFromConfig(config.token, orgId, db) : undefined;
     const token = tokenResult?.token ?? FALLBACK_GITLAB_TOKEN;
-    const secretKey = tokenResult?.secretKey;
 
     const api = new Gitlab({
         ...(token ? {

packages/db/prisma/migrations/20250225183123_add_synced_with_warnings_to_connection_sync_status/migration.sql

@@ -0,0 +1,2 @@
+-- AlterEnum
+ALTER TYPE "ConnectionSyncStatus" ADD VALUE 'SYNCED_WITH_WARNINGS';

packages/db/prisma/schema.prisma

@@ -26,6 +26,7 @@ enum ConnectionSyncStatus {
   IN_SYNC_QUEUE
   SYNCING
   SYNCED
+  SYNCED_WITH_WARNINGS
   FAILED
 }
 

packages/web/next.config.mjs

@@ -26,11 +26,7 @@ const nextConfig = {
         remotePatterns: [
             {
                 protocol: 'https',
-                hostname: 'avatars.githubusercontent.com',
-            },
-            {
-                protocol: 'https',
-                hostname: 'gitlab.com',
+                hostname: '**',
             },
         ]
     }