-
Notifications
You must be signed in to change notification settings - Fork 174
Fix components extending beyond screen dimensions on mobile view #2792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…e issue of extending beyond mobile screen dimensions
…d mobile screen dimensions
sayomaki
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes! I have also added some minor style updates, and have fixed the formatting as well as tests for you.
Pull Request Test Coverage Report for Build 8053090629Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
* Use classnames for conditional styling * Replace unnecessary template literal with strings
RichDom2185
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the test snapshots, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me (and working), thanks for the changes!
RichDom2185
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Description
Closes #2241
The following components extend beyond the screen dimensions on mobile view:
ConfirmDialogandPromptDialogOverviewCardType of change
How to test
On a Mobile view:
ConfirmDialogandPromptDialogSICP "Text Search" and "Index Search" search bar
Assessment
OverviewCardChecklist