From cce15a6fbd109a55adc3bf080c66a255c4f6c2d6 Mon Sep 17 00:00:00 2001 From: "CORP\\11rschaub" Date: Sat, 9 Mar 2019 21:38:11 +0100 Subject: [PATCH] Event Time "et": add non measurement protocol parameter, can be used by a server side dispatcher to re-adjust "qt". "et" itselve will be ignored by Google. Updated Version --- .gitignore | 3 +++ Source/CSharpAnalytics.Tests/Properties/AssemblyInfo.cs | 4 ++-- .../Protocols/Measurement/MeasurementAnalyticsClientTests.cs | 3 ++- Source/CSharpAnalytics/Properties/AssemblyInfo.cs | 4 ++-- .../Protocols/Measurement/MeasurementAnalyticsClient.cs | 3 +++ .../Properties/AssemblyInfo.cs | 4 ++-- 6 files changed, 14 insertions(+), 7 deletions(-) diff --git a/.gitignore b/.gitignore index b8c03b3..858af75 100644 --- a/.gitignore +++ b/.gitignore @@ -184,3 +184,6 @@ $RECYCLE.BIN/ # Roslyn VS2015 junk *.sln.ide/ *.nupkg + +# Visual Studio temp and user data +*/.vs/ diff --git a/Source/CSharpAnalytics.Tests/Properties/AssemblyInfo.cs b/Source/CSharpAnalytics.Tests/Properties/AssemblyInfo.cs index ebfb0c4..48c0593 100644 --- a/Source/CSharpAnalytics.Tests/Properties/AssemblyInfo.cs +++ b/Source/CSharpAnalytics.Tests/Properties/AssemblyInfo.cs @@ -5,7 +5,7 @@ [assembly: AssemblyProduct("CSharpAnalytics")] [assembly: AssemblyCopyright("Copyright © 2012-2014 Attack Pattern LLC.")] -[assembly: AssemblyVersion("1.4.0.0")] -[assembly: AssemblyFileVersion("1.4.0.0")] +[assembly: AssemblyVersion("1.5.0.0")] +[assembly: AssemblyFileVersion("1.5.0.0")] [assembly: AssemblyDescriptionAttribute("Unit tests for CSharpAnalytics")] [assembly: NeutralResourcesLanguageAttribute("")] \ No newline at end of file diff --git a/Source/CSharpAnalytics.Tests/Protocols/Measurement/MeasurementAnalyticsClientTests.cs b/Source/CSharpAnalytics.Tests/Protocols/Measurement/MeasurementAnalyticsClientTests.cs index f147180..c113d3d 100644 --- a/Source/CSharpAnalytics.Tests/Protocols/Measurement/MeasurementAnalyticsClientTests.cs +++ b/Source/CSharpAnalytics.Tests/Protocols/Measurement/MeasurementAnalyticsClientTests.cs @@ -115,13 +115,14 @@ public void MeasurementAnalyticsClient_SetCustomMetric_Decimal_Is_Sent() } [TestMethod] - public void MeasurementAnalyticsClient_AdjustUriBeforeRequest_Adds_Qt_Parameter() + public void MeasurementAnalyticsClient_AdjustUriBeforeRequest_Adds_TimeStamp_Parameters() { var originalUri = new Uri("http://anything.really.com/something#" + DateTime.UtcNow.ToString("o")); var actual = new MeasurementAnalyticsClient().AdjustUriBeforeRequest(originalUri); StringAssert.Contains(actual.Query, "qt="); + StringAssert.Contains(actual.Query, "et="); } [TestMethod] diff --git a/Source/CSharpAnalytics/Properties/AssemblyInfo.cs b/Source/CSharpAnalytics/Properties/AssemblyInfo.cs index ae11683..edcb0fe 100644 --- a/Source/CSharpAnalytics/Properties/AssemblyInfo.cs +++ b/Source/CSharpAnalytics/Properties/AssemblyInfo.cs @@ -8,8 +8,8 @@ [assembly: AssemblyProduct("CSharpAnalytics")] [assembly: AssemblyCopyright("Copyright © 2012-2014 Attack Pattern LLC.")] -[assembly: AssemblyVersion("1.4.0.0")] -[assembly: AssemblyFileVersion("1.4.0.0")] +[assembly: AssemblyVersion("1.5.0.0")] +[assembly: AssemblyFileVersion("1.5.0.0")] [assembly: ComVisible(false)] [assembly: InternalsVisibleTo("CSharpAnalytics.Test.Net45")] diff --git a/Source/CSharpAnalytics/Protocols/Measurement/MeasurementAnalyticsClient.cs b/Source/CSharpAnalytics/Protocols/Measurement/MeasurementAnalyticsClient.cs index 5f8e60d..eafad82 100644 --- a/Source/CSharpAnalytics/Protocols/Measurement/MeasurementAnalyticsClient.cs +++ b/Source/CSharpAnalytics/Protocols/Measurement/MeasurementAnalyticsClient.cs @@ -269,6 +269,9 @@ private static void AddQueueTimeFromFragment(Uri uri, IDictionary