Introduce support for discard.

Author: ioquatix

lib/protocol/http/body/buffered.rb

@@ -59,6 +59,8 @@ def finish
 				# Ensure that future reads return nil, but allow for rewinding.
 				def close(error = nil)
 					@index = @chunks.length
+					
+					return nil
 				end
 
 				def clear
@@ -91,7 +93,7 @@ def read
 				end
 
 				def discard
-					clear
+					self.close
 				end
 
 				def write(chunk)

lib/protocol/http/body/readable.rb

@@ -133,9 +133,13 @@ def finish
 					Buffered.read(self)
 				end
 
+				# Discard the body as efficiently as possible.
+				#
+				# The default implementation simply reads all chunks until the body is empty.
+				#
+				# Useful for discarding the body when it is not needed, but preserving the underlying connection.
 				def discard
 					while chunk = self.read
-						chunk.clear
 					end
 				end
 

test/protocol/http/body/buffered.rb

@@ -175,4 +175,12 @@
 			expect(body.inspect).to be =~ /\d+ chunks, \d+ bytes/
 		end
 	end
+	
+	with "#discard" do
+		it "closes the body" do
+			expect(body).to receive(:close)
+			
+			expect(body.discard).to be == nil
+		end
+	end
 end

test/protocol/http/body/readable.rb

@@ -58,6 +58,13 @@
 		end
 	end
 
+	with "#discard" do
+		it "should read all chunks" do
+			expect(body).to receive(:read).and_return(nil)
+			expect(body.discard).to be_nil
+		end
+	end
+	
 	with "#as_json" do
 		it "generates a JSON representation" do
 			expect(body.as_json).to have_keys(

test/protocol/http/body/reader.rb

@@ -29,6 +29,13 @@ def initialize(body)
 		end
 	end
 
+	with "#discard" do
+		it 'discards the body' do
+			expect(body).to receive(:discard)
+			expect(reader.discard).to be_nil
+		end
+	end
+	
 	with '#buffered!' do
 		it 'buffers the body' do
 			expect(reader.buffered!).to be_equal(reader)

test/protocol/http/body/wrapper.rb

@@ -104,4 +104,11 @@
 			body.call(stream)
 		end
 	end
+	
+	with "#discard" do
+		it "should proxy discard" do
+			expect(source).to receive(:discard).and_return(nil)
+			expect(body.discard).to be_nil
+		end
+	end
 end