From 2e93f043d5a694c352b07f3c4d616f7e6fed3bcf Mon Sep 17 00:00:00 2001 From: Abu Zafor Fagun Date: Tue, 16 Mar 2021 00:24:57 +0600 Subject: [PATCH 1/3] Fix issue #60 --- src/Chronicle/Managers/SagaCoordinator.cs | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/src/Chronicle/Managers/SagaCoordinator.cs b/src/Chronicle/Managers/SagaCoordinator.cs index 9e877b8..15c9722 100644 --- a/src/Chronicle/Managers/SagaCoordinator.cs +++ b/src/Chronicle/Managers/SagaCoordinator.cs @@ -58,8 +58,14 @@ private async Task ProcessAsync(TMessage message, ISagaAction Date: Wed, 17 Mar 2021 01:23:09 +0600 Subject: [PATCH 2/3] Do not throw exception from reject If we throw the exception, azure service bus ExceptionReceivedHandler take it to re process the message --- src/Chronicle/Saga.cs | 1 - 1 file changed, 1 deletion(-) diff --git a/src/Chronicle/Saga.cs b/src/Chronicle/Saga.cs index db5c39a..fbd90a5 100644 --- a/src/Chronicle/Saga.cs +++ b/src/Chronicle/Saga.cs @@ -27,7 +27,6 @@ public virtual Task CompleteAsync() public virtual void Reject(Exception innerException = null) { State = SagaStates.Rejected; - throw new ChronicleException("Saga rejection called by method", innerException); } public virtual Task RejectAsync(Exception innerException = null) From 638f612e4dee546f50e695e0e9303c9df65cc7c4 Mon Sep 17 00:00:00 2001 From: Abu Zafor Fagun Date: Wed, 17 Mar 2021 01:26:11 +0600 Subject: [PATCH 3/3] Revert "Fix issue #60" This reverts commit 2e93f043d5a694c352b07f3c4d616f7e6fed3bcf. --- src/Chronicle/Managers/SagaCoordinator.cs | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/src/Chronicle/Managers/SagaCoordinator.cs b/src/Chronicle/Managers/SagaCoordinator.cs index 15c9722..9e877b8 100644 --- a/src/Chronicle/Managers/SagaCoordinator.cs +++ b/src/Chronicle/Managers/SagaCoordinator.cs @@ -58,14 +58,8 @@ private async Task ProcessAsync(TMessage message, ISagaAction