Skip to content

Commit af7e5c5

Browse files
authored
misc: upgrade to Dokka 2.0.0 (#1284)
1 parent da208cd commit af7e5c5

File tree

27 files changed

+262
-335
lines changed

27 files changed

+262
-335
lines changed
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
{
2+
"id": "50a9ce20-c4d7-4952-8fad-f9ffb38c9259",
3+
"type": "misc",
4+
"description": "Upgrade to Dokka 2.0.0"
5+
}

.editorconfig

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,4 +9,4 @@ ktlint_standard_backing-property-naming = disabled
99
# enable trailing commas per JetBrains recommendation
1010
# (https://kotlinlang.org/docs/coding-conventions.html#trailing-commas)
1111
ij_kotlin_allow_trailing_comma_on_call_site = true
12-
ij_kotlin_allow_trailing_comma = true
12+
ij_kotlin_allow_trailing_comma = true

build.gradle.kts

Lines changed: 14 additions & 48 deletions
Original file line numberDiff line numberDiff line change
@@ -18,13 +18,13 @@ buildscript {
1818
}
1919

2020
plugins {
21-
alias(libs.plugins.dokka)
21+
`dokka-convention`
2222
alias(libs.plugins.kotlinx.binary.compatibility.validator)
23+
alias(libs.plugins.aws.kotlin.repo.tools.artifactsizemetrics)
2324
// ensure the correct version of KGP ends up on our buildscript classpath
2425
// since build-plugins also has <some> version in its dependency closure
25-
alias(libs.plugins.kotlin.multiplatform) apply false
26-
alias(libs.plugins.kotlin.jvm) apply false
27-
alias(libs.plugins.aws.kotlin.repo.tools.artifactsizemetrics)
26+
id(libs.plugins.kotlin.multiplatform.get().pluginId) apply false
27+
id(libs.plugins.kotlin.jvm.get().pluginId) apply false
2828
}
2929

3030
artifactSizeMetrics {
@@ -40,35 +40,9 @@ val testJavaVersion = typedProp<String>("test.java.version")?.let {
4040
}
4141

4242
allprojects {
43-
tasks.withType<org.jetbrains.dokka.gradle.AbstractDokkaTask>().configureEach {
44-
val sdkVersion: String by project
45-
moduleVersion.set(sdkVersion)
46-
47-
val year = java.time.LocalDate.now().year
48-
val pluginConfigMap = mapOf(
49-
"org.jetbrains.dokka.base.DokkaBase" to """
50-
{
51-
"customStyleSheets": [
52-
"${rootProject.file("docs/dokka-presets/css/logo-styles.css")}",
53-
"${rootProject.file("docs/dokka-presets/css/aws-styles.css")}"
54-
],
55-
"customAssets": [
56-
"${rootProject.file("docs/dokka-presets/assets/logo-icon.svg")}",
57-
"${rootProject.file("docs/dokka-presets/assets/aws_logo_white_59x35.png")}",
58-
"${rootProject.file("docs/dokka-presets/scripts/accessibility.js")}"
59-
],
60-
"footerMessage": "© $year, Amazon Web Services, Inc. or its affiliates. All rights reserved.",
61-
"separateInheritedMembers" : true,
62-
"templatesDir": "${rootProject.file("docs/dokka-presets/templates")}"
63-
}
64-
""",
65-
)
66-
pluginsMapConfiguration.set(pluginConfigMap)
67-
}
68-
6943
if (rootProject.typedProp<Boolean>("kotlinWarningsAsErrors") == true) {
7044
tasks.withType<org.jetbrains.kotlin.gradle.tasks.KotlinCompile> {
71-
kotlinOptions.allWarningsAsErrors = true
45+
compilerOptions.allWarningsAsErrors = true
7246
}
7347
}
7448

@@ -90,27 +64,18 @@ allprojects {
9064
}
9165

9266
// configure the root multimodule docs
93-
tasks.dokkaHtmlMultiModule.configure {
67+
dokka {
9468
moduleName.set("Smithy Kotlin")
9569

96-
// Output subprojects' docs to <docs-base>/project-name/* instead of <docs-base>/path/to/project-name/*
97-
// This is especially important for inter-repo linking (e.g., via externalDocumentationLink) because the
98-
// package-list doesn't contain enough project path information to indicate where modules' documentation are
99-
// located.
100-
fileLayout.set { parent, child ->
101-
parent.outputDirectory.dir(child.moduleName)
70+
dokkaPublications.html {
71+
includes.from(
72+
rootProject.file("docs/dokka-presets/README.md"),
73+
)
10274
}
75+
}
10376

104-
includes.from(
105-
// NOTE: these get concatenated
106-
rootProject.file("docs/dokka-presets/README.md"),
107-
)
108-
109-
val excludeFromDocumentation = listOf(
110-
project(":runtime:testing"),
111-
project(":runtime:smithy-test"),
112-
)
113-
removeChildTasks(excludeFromDocumentation)
77+
dependencies {
78+
dokka(project(":runtime"))
11479
}
11580

11681
// Publishing
@@ -121,6 +86,7 @@ val lintPaths = listOf(
12186
"**/*.{kt,kts}",
12287
"!**/generated-src/**",
12388
"!**/smithyprojections/**",
89+
"!**/build/**",
12490
)
12591

12692
configureLinting(lintPaths)

buildSrc/build.gradle.kts

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
plugins {
2+
`kotlin-dsl`
3+
}
4+
5+
repositories {
6+
mavenCentral()
7+
gradlePluginPortal()
8+
}
9+
10+
dependencies {
11+
implementation(libs.dokka.gradle.plugin)
12+
implementation(libs.kotlin.gradle.plugin)
13+
}

buildSrc/settings.gradle.kts

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
rootProject.name = "buildSrc"
2+
3+
dependencyResolutionManagement {
4+
versionCatalogs {
5+
create("libs") {
6+
from(files("../gradle/libs.versions.toml"))
7+
}
8+
}
9+
}
Lines changed: 30 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,30 @@
1+
import kotlin.text.set
2+
3+
plugins {
4+
id("org.jetbrains.dokka")
5+
}
6+
7+
dokka {
8+
val sdkVersion: String by project
9+
moduleVersion.set(sdkVersion)
10+
11+
pluginsConfiguration.html {
12+
customStyleSheets.from(
13+
rootProject.file("docs/dokka-presets/css/aws-styles.css"),
14+
)
15+
16+
customAssets.from(
17+
rootProject.file("docs/dokka-presets/assets/logo-icon.svg"),
18+
rootProject.file("docs/dokka-presets/scripts/accessibility.js"),
19+
)
20+
21+
templatesDir.set(rootProject.file("docs/dokka-presets/templates"))
22+
23+
footerMessage.set("© ${java.time.LocalDate.now().year}, Amazon Web Services, Inc. or its affiliates. All rights reserved.")
24+
separateInheritedMembers.set(true)
25+
}
26+
}
27+
28+
dependencies {
29+
dokkaPlugin(project(":dokka-smithy"))
30+
}

codegen/smithy-aws-kotlin-codegen/build.gradle.kts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import org.jetbrains.kotlin.gradle.dsl.JvmTarget
77
import org.jetbrains.kotlin.gradle.tasks.KotlinCompile
88

99
plugins {
10-
alias(libs.plugins.kotlin.jvm)
10+
id(libs.plugins.kotlin.jvm.get().pluginId)
1111
jacoco
1212
`maven-publish`
1313
}

codegen/smithy-kotlin-codegen-testutils/build.gradle.kts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import org.jetbrains.kotlin.gradle.dsl.JvmTarget
77
import org.jetbrains.kotlin.gradle.tasks.KotlinCompile
88

99
plugins {
10-
alias(libs.plugins.kotlin.jvm)
10+
id(libs.plugins.kotlin.jvm.get().pluginId)
1111
jacoco
1212
`maven-publish`
1313
}

codegen/smithy-kotlin-codegen/build.gradle.kts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import org.jetbrains.kotlin.gradle.dsl.JvmTarget
77
import org.jetbrains.kotlin.gradle.tasks.KotlinCompile
88

99
plugins {
10-
alias(libs.plugins.kotlin.jvm)
10+
id(libs.plugins.kotlin.jvm.get().pluginId)
1111
jacoco
1212
`maven-publish`
1313
}
-2.22 KB
Binary file not shown.

0 commit comments

Comments
 (0)