Simplify OutputFormat from int to string type

Change OutputFormat from an int-based custom type with String(), Set(),
and Type() methods to simple string constants. This eliminates unnecessary
type conversion logic between int and string.

- Remove OutputFormat custom type and its methods
- Use string constants: OutputFormatText = "text", OutputFormatJSON = "json"
- Update format field in outputOptions from OutputFormat to string
- Change flag registration from Var() to StringVar() in audit.go and verifycommit.go
- Update tests to use string type instead of OutputFormat type
- Remove obsolete tests for OutputFormat.String() and OutputFormat.Set()

This addresses code review feedback requesting a simpler string-based
approach instead of the int-based enum pattern.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>
Signed-off-by: Ralph Bean <[email protected]>

Author: ralphbean

internal/cmd/audit.go

@@ -114,7 +114,7 @@ func (ao *auditOpts) AddFlags(cmd *cobra.Command) {
 	ao.auditMode = AuditModeBasic
 	cmd.PersistentFlags().Var(&ao.auditMode, "audit-mode", "'basic' for limited details (default), 'full' for all details")
 	ao.format = OutputFormatText
-	cmd.PersistentFlags().Var(&ao.format, "format", "Output format: 'text' (default) or 'json'")
+	cmd.PersistentFlags().StringVar(&ao.format, "format", OutputFormatText, "Output format: 'text' (default) or 'json'")
 }
 
 func addAudit(parentCmd *cobra.Command) {

internal/cmd/output.go

@@ -5,52 +5,19 @@ package cmd
 
 import (
 	"encoding/json"
-	"errors"
 	"fmt"
 	"io"
 	"os"
 )
 
-type OutputFormat int
-
 const (
-	OutputFormatText OutputFormat = 1
-	OutputFormatJSON OutputFormat = 2
+	OutputFormatText = "text"
+	OutputFormatJSON = "json"
 )
 
-// String is used both by fmt.Print and by Cobra in help text
-func (e *OutputFormat) String() string {
-	switch *e {
-	case OutputFormatText:
-		return "text"
-	case OutputFormatJSON:
-		return "json"
-	}
-	return "error"
-}
-
-// Set must have pointer receiver so it doesn't change the value of a copy
-func (e *OutputFormat) Set(v string) error {
-	switch v {
-	case "text":
-		*e = OutputFormatText
-		return nil
-	case "json":
-		*e = OutputFormatJSON
-		return nil
-	default:
-		return errors.New(`must be one of "text" or "json"`)
-	}
-}
-
-// Type is only used in help text
-func (e *OutputFormat) Type() string {
-	return "OutputFormat"
-}
-
 // outputOptions provides common output formatting options
 type outputOptions struct {
-	format OutputFormat
+	format string
 	writer io.Writer
 }
 

internal/cmd/verifycommit.go

@@ -56,7 +56,7 @@ func (vco *verifyCommitOptions) AddFlags(cmd *cobra.Command) {
 		&vco.tag, "tag", "", "The tag within the repository",
 	)
 	vco.format = OutputFormatText
-	cmd.PersistentFlags().Var(&vco.format, "format", "Output format: 'text' (default) or 'json'")
+	cmd.PersistentFlags().StringVar(&vco.format, "format", OutputFormatText, "Output format: 'text' (default) or 'json'")
 }
 
 //nolint:dupl

internal/cmd/verifycommit_test.go

@@ -126,7 +126,7 @@ func TestOutputOptions_WriteJSON(t *testing.T) {
 func TestOutputOptions_IsJSON(t *testing.T) {
 	tests := []struct {
 		name   string
-		format OutputFormat
+		format string
 		want   bool
 	}{
 		{
@@ -150,71 +150,3 @@ func TestOutputOptions_IsJSON(t *testing.T) {
 		})
 	}
 }
-
-func TestOutputFormat_String(t *testing.T) {
-	tests := []struct {
-		name   string
-		format OutputFormat
-		want   string
-	}{
-		{
-			name:   "text format",
-			format: OutputFormatText,
-			want:   "text",
-		},
-		{
-			name:   "JSON format",
-			format: OutputFormatJSON,
-			want:   "json",
-		},
-	}
-
-	for _, tt := range tests {
-		t.Run(tt.name, func(t *testing.T) {
-			if got := tt.format.String(); got != tt.want {
-				t.Errorf("String() = %v, want %v", got, tt.want)
-			}
-		})
-	}
-}
-
-func TestOutputFormat_Set(t *testing.T) {
-	tests := []struct {
-		name    string
-		value   string
-		want    OutputFormat
-		wantErr bool
-	}{
-		{
-			name:    "set to text",
-			value:   "text",
-			want:    OutputFormatText,
-			wantErr: false,
-		},
-		{
-			name:    "set to json",
-			value:   "json",
-			want:    OutputFormatJSON,
-			wantErr: false,
-		},
-		{
-			name:    "invalid value",
-			value:   "invalid",
-			wantErr: true,
-		},
-	}
-
-	for _, tt := range tests {
-		t.Run(tt.name, func(t *testing.T) {
-			var format OutputFormat
-			err := format.Set(tt.value)
-			if (err != nil) != tt.wantErr {
-				t.Errorf("Set() error = %v, wantErr %v", err, tt.wantErr)
-				return
-			}
-			if !tt.wantErr && format != tt.want {
-				t.Errorf("Set() got = %v, want %v", format, tt.want)
-			}
-		})
-	}
-}