Skip to content

Commit e50d98c

Browse files
committed
Fix some incorrect NNBD tests.
Closes dart-lang/sdk#39814 Closes dart-lang/sdk#39823 Closes dart-lang/sdk#39816 Change-Id: I5015d5cb43b27a555360423cc9567c5880c948e3 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128777 Reviewed-by: Erik Ernst <[email protected]>
1 parent 52c6620 commit e50d98c

File tree

3 files changed

+8
-7
lines changed

3 files changed

+8
-7
lines changed

tests/language/nnbd/static_errors/not_assigned_local_initializer_test.dart

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,18 +15,19 @@ void main() {
1515
int v; v; //# 01: compile-time error
1616
int v; //# 02: ok
1717
int v = 0; v; //# 03: ok
18-
late int v; v; //# 04: ok
18+
late int v; v; //# 04: compile-time error
1919
late int v = 0; v; //# 05: ok
2020
int? v; v; //# 06: ok
2121
int? v = 0; v; //# 07: ok
22-
22+
f<int?>(null);
23+
f<int>(0);
2324
}
2425

2526
f<T>(T a) {
2627
T v; v; //# 08: compile-time error
2728
T v; //# 09: ok
2829
T v = a; v; //# 10: ok
29-
late T v; v; //# 11: ok
30+
late T v; v; //# 11: compile-time error
3031
late T v = a; v; //# 12: ok
3132
T? v; v; //# 13: ok
3233
T? v = a; v; //# 14: ok

tests/language/nnbd/static_errors/unchecked_use_of_nullable_test.dart

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ void main() async {
4444
while (cond) {} //# 27: compile-time error
4545
for (;cond;) {} //# 28: compile-time error
4646
do {} while (cond); //# 29: compile-time error
47-
cond!; //# 30: ok
47+
cond!; //# 30: runtime error
4848
cond ?? null; //# 31: ok
4949
cond == null; //# 32: ok
5050
cond != null; //# 33: ok
@@ -102,7 +102,7 @@ void typeParametersNullableBounds<IQ extends int?, BQ extends bool?, LQ extends
102102
while (cond) {} //# 71: compile-time error
103103
for (;cond;){} //# 72: compile-time error
104104
do {} while (cond); //# 73: compile-time error
105-
cond!; //# 74: ok
105+
cond!; //# 74: runtime error
106106
cond ?? null; //# 75: ok
107107
cond == null; //# 76: ok
108108
cond != null; //# 77: ok
@@ -153,7 +153,7 @@ void typeParametersNullableUses<I extends int, B extends bool, L extends List, F
153153
while (cond) {} //# 111: compile-time error
154154
for (;cond;) {} //# 112: compile-time error
155155
do {} while (cond); //# 113: compile-time error
156-
cond!; //# 114: ok
156+
cond!; //# 114: runtime error
157157
cond ?? null; //# 115: ok
158158
cond == null; //# 116: ok
159159
cond != null; //# 117: ok

tests/language/nnbd/syntax/class_member_declarations_test.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,5 +76,5 @@ abstract class B {
7676
main() {
7777
A? a;
7878
String? s = '';
79-
a?..foo().length..x27 = s!..toString().length;
79+
a?..foo().length..x27 = s!.toString().length;
8080
}

0 commit comments

Comments
 (0)