Version 2.13.0-132.0.dev

Merge commit '3c5767ccd34d0aeaf084bbf50b0849e24c17d710' into 'dev'

Author: Dart CI

pkg/analysis_server/lib/src/services/completion/statement/statement_completion.dart

@@ -427,14 +427,8 @@ class StatementCompletionProcessor {
     }
     DoStatement statement = node;
     var sb = _sourceBuilderAfterKeyword(statement.doKeyword);
-    // I modified the code and ran the tests with both the old and new parser.
-    // Apparently the old parser sometimes sticks something other than 'while'
-    // into the whileKeyword field, which causes statement completion to throw
-    // an exception further downstream.
-    // TODO(danrubel): change `statement.whileKeyword?.lexeme == "while"`
-    // to `statement.whileKeyword != null` once the fasta parser is the default.
-    var hasWhileKeyword = statement.whileKeyword?.lexeme == 'while' &&
-        !statement.whileKeyword.isSynthetic;
+    var hasWhileKeyword =
+        statement.whileKeyword != null && !statement.whileKeyword.isSynthetic;
     var exitDelta = 0;
     if (!_statementHasValidBody(statement.doKeyword, statement.body)) {
       var text = utils.getNodeText(statement.body);

pkg/analysis_server/test/services/completion/dart/completion_contributor_util.dart

@@ -96,8 +96,6 @@ abstract class _BaseDartCompletionContributorTest extends AbstractContextTest
   /// where there is no `new` or `const` keyword.
   bool get suggestConstructorsWithoutNew => true;
 
-  bool get usingFastaParser => true;
-
   void addTestSource(String content) {
     expect(completionOffset, isNull, reason: 'Call addTestUnit exactly once');
     completionOffset = content.indexOf('^');

pkg/analysis_server/test/services/completion/dart/keyword_contributor_test.dart

@@ -528,9 +528,7 @@ class KeywordContributorTest extends DartCompletionContributorTest {
   Future<void> test_anonymous_function_async7() async {
     addTestSource('main() {foo("bar", () as^ => null');
     await computeSuggestions();
-    assertSuggestKeywords([],
-        pseudoKeywords:
-            usingFastaParser ? ['async'] : ['async', 'async*', 'sync*']);
+    assertSuggestKeywords([], pseudoKeywords: ['async']);
   }
 
   Future<void> test_anonymous_function_async8() async {
@@ -916,17 +914,13 @@ class KeywordContributorTest extends DartCompletionContributorTest {
   Future<void> test_class_implements2() async {
     addTestSource('class A e^ implements foo');
     await computeSuggestions();
-    assertSuggestKeywords(usingFastaParser
-        ? [Keyword.EXTENDS]
-        : [Keyword.EXTENDS, Keyword.IMPLEMENTS]);
+    assertSuggestKeywords([Keyword.EXTENDS]);
   }
 
   Future<void> test_class_implements3() async {
     addTestSource('class A e^ implements foo { }');
     await computeSuggestions();
-    assertSuggestKeywords(usingFastaParser
-        ? [Keyword.EXTENDS]
-        : [Keyword.EXTENDS, Keyword.IMPLEMENTS]);
+    assertSuggestKeywords([Keyword.EXTENDS]);
   }
 
   Future<void> test_class_implements_name() async {

pkg/analysis_server/test/services/completion/statement/statement_completion_test.dart

@@ -1398,17 +1398,7 @@ main() {
         (s) => _afterLast(s, '  '));
   }
 
-  @failingTest
   Future<void> test_noCloseParenWithSemicolon() async {
-    // TODO(danrubel):
-    // Fasta scanner produces an error message which is converted into
-    // an Analyzer error message before the fasta parser gets a chance
-    // to move it along with the associated synthetic ')' to a more
-    // appropriate location. This means that some statement completions,
-    // which are expecting errors in a particular location, don't work.
-    // Fixing this properly means modifying the scanner not to generate
-    // closing ')', then updating the parser to handle that situation.
-    // This is a fair amount of work and won't be tackled today.
     var before = '''
 main() {
   var s = 'sample'.substring(3;
@@ -1427,12 +1417,6 @@ main() {
     await _prepareCompletion('ing(3;', before, atEnd: true);
     _assertHasChange('Insert a newline at the end of the current line', after,
         (s) => _afterLast(s, '  '));
-
-    // The old Analyzer parser passes this test, but will be turned off soon.
-    // It is preferable to throw only if the old analyzer is being used,
-    // but there does not seem to be a reliable way to determine that here.
-    // TODO(danrubel): remove this once fasta parser is enabled by default.
-    throw 'remove this once fasta parser is enabled by default';
   }
 
   Future<void> test_semicolonFn() async {
@@ -1507,12 +1491,6 @@ main() {
 f() {}
 ''',
         (s) => _afterLast(s, '  '));
-
-    // The old Analyzer parser passes this test, but will be turned off soon.
-    // It is preferable to throw only if the old analyzer is being used,
-    // but there does not seem to be a reliable way to determine that here.
-    // TODO(danrubel): remove this once fasta parser is enabled by default.
-    throw 'remove this once fasta parser is enabled by default';
   }
 
   Future<void> test_semicolonFnExpr() async {

pkg/compiler/lib/src/elements/types.dart

@@ -1381,7 +1381,7 @@ abstract class DartTypeStructuralPredicateVisitor
 
   @override
   bool visitNeverType(NeverType type, List<FunctionTypeVariable> bindings) =>
-      false;
+      handleNeverType(type);
 
   @override
   bool visitVoidType(VoidType type, List<FunctionTypeVariable> bindings) =>

pkg/compiler/lib/src/js_backend/impact_transformer.dart

@@ -415,11 +415,17 @@ class CodegenImpactTransformer {
         case ConstantValueKind.SET:
         case ConstantValueKind.MAP:
         case ConstantValueKind.CONSTRUCTED:
-        case ConstantValueKind.INSTANTIATION:
         case ConstantValueKind.LIST:
           transformed.registerStaticUse(StaticUse.staticInvoke(
               _closedWorld.commonElements.findType, CallStructure.ONE_ARG));
           break;
+        case ConstantValueKind.INSTANTIATION:
+          transformed.registerStaticUse(StaticUse.staticInvoke(
+              _closedWorld.commonElements.findType, CallStructure.ONE_ARG));
+          InstantiationConstantValue instantiation = constantUse.value;
+          _rtiChecksBuilder.registerGenericInstantiation(GenericInstantiation(
+              instantiation.function.type, instantiation.typeArguments));
+          break;
         case ConstantValueKind.DEFERRED_GLOBAL:
           _closedWorld.outputUnitData
               .registerConstantDeferredUse(constantUse.value);

pkg/compiler/lib/src/js_backend/runtime_types.dart

@@ -533,7 +533,6 @@ class RuntimeTypesImpl
     TypeVariableTests typeVariableTests = new TypeVariableTests(
         _elementEnvironment,
         _commonElements,
-        _types,
         codegenWorld,
         _genericInstantiations,
         forRtiNeeds: false);