Skip to content

Commit b509bbb

Browse files
egdanielSkia Commit-Bot
authored andcommitted
Remove some unneed read access from vk srcAccessMasks.
There is not need to have read accesses list in the srcAccessMask of barriers. This is cause the srcAccessMask is used to make writes to memory available and reads obviously have no writes. Change-Id: I2fb1eca04d6f216bc63e200ad36bacdb40bf8146 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/321785 Auto-Submit: Greg Daniel <[email protected]> Commit-Queue: Jim Van Verth <[email protected]> Reviewed-by: Jim Van Verth <[email protected]>
1 parent a3f22f1 commit b509bbb

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

src/gpu/vk/GrVkImage.cpp

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -93,13 +93,11 @@ VkAccessFlags GrVkImage::LayoutToSrcAccessMask(const VkImageLayout layout) {
9393
flags = VK_ACCESS_COLOR_ATTACHMENT_WRITE_BIT |
9494
VK_ACCESS_DEPTH_STENCIL_ATTACHMENT_WRITE_BIT |
9595
VK_ACCESS_TRANSFER_WRITE_BIT |
96-
VK_ACCESS_TRANSFER_READ_BIT |
97-
VK_ACCESS_SHADER_READ_BIT |
98-
VK_ACCESS_HOST_WRITE_BIT | VK_ACCESS_HOST_READ_BIT;
96+
VK_ACCESS_HOST_WRITE_BIT;
9997
} else if (VK_IMAGE_LAYOUT_PREINITIALIZED == layout) {
10098
flags = VK_ACCESS_HOST_WRITE_BIT;
10199
} else if (VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL == layout) {
102-
flags = VK_ACCESS_COLOR_ATTACHMENT_WRITE_BIT | VK_ACCESS_COLOR_ATTACHMENT_READ_BIT;
100+
flags = VK_ACCESS_COLOR_ATTACHMENT_WRITE_BIT;
103101
} else if (VK_IMAGE_LAYOUT_DEPTH_STENCIL_ATTACHMENT_OPTIMAL == layout) {
104102
flags = VK_ACCESS_DEPTH_STENCIL_ATTACHMENT_WRITE_BIT;
105103
} else if (VK_IMAGE_LAYOUT_TRANSFER_DST_OPTIMAL == layout) {

0 commit comments

Comments
 (0)