From 992702a6dad855235fcc00c90f02ac7c2cc24ffe Mon Sep 17 00:00:00 2001 From: jrfnl Date: Sat, 25 Sep 2021 20:41:03 +0200 Subject: [PATCH] PHPUnit: update configuration PHPUnit just released version 9.5.10 and 8.5.21. This contains a particular (IMO breaking) change: > * PHPUnit no longer converts PHP deprecations to exceptions by default (configure `convertDeprecationsToExceptions="true"` to enable this) Let's unpack this: Previously (PHPUnit < 9.5.10/8.5.21), if PHPUnit would encounter a PHP native deprecation notice, it would: 1. Show a test which causes a deprecation notice to be thrown as **"errored"**, 2. Show the **first** deprecation notice it encountered and 3. PHPUnit would exit with a **non-0 exit code** (2), which will fail a CI build. As of PHPUnit 9.5.10/8.5.21, if PHPUnit encounters a PHP native deprecation notice, it will no longer do so. Instead PHPUnit will: 1. Show a test which causes a PHP deprecation notice to be thrown as **"risky"**, 2. Show the **all** deprecation notices it encountered and 3. PHPUnit will exit with a **0 exit code**, which will show a CI build as passing. This commit reverts PHPUnit to the previous behaviour by adding `convertDeprecationsToExceptions="true"` to the PHPUnit configuration. It also adds the other related directives for consistency. Refs: * https://github.com/sebastianbergmann/phpunit/blob/9.5/ChangeLog-8.5.md * https://github.com/sebastianbergmann/phpunit/blob/9.5/ChangeLog-9.5.md --- phpunit.circleci.xml | 4 ++++ phpunit.xml.dist | 4 ++++ 2 files changed, 8 insertions(+) diff --git a/phpunit.circleci.xml b/phpunit.circleci.xml index 32dac349..1fac1fc3 100644 --- a/phpunit.circleci.xml +++ b/phpunit.circleci.xml @@ -1,5 +1,9 @@ diff --git a/phpunit.xml.dist b/phpunit.xml.dist index 07f4fd1f..6a3d3540 100644 --- a/phpunit.xml.dist +++ b/phpunit.xml.dist @@ -1,6 +1,10 @@