From 24e2afda658c88073ce381c313db4cd2d5b4d51a Mon Sep 17 00:00:00 2001 From: Payton Swick Date: Tue, 15 Sep 2020 11:43:08 -0400 Subject: [PATCH 1/2] Add more superglobals to test fixture This adds the missing `$HTTP_RAW_POST_DATA`, `$http_response_header`, and `$php_errormsg`. --- .../fixtures/FunctionWithGlobalVarFixture.php | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/Tests/VariableAnalysisSniff/fixtures/FunctionWithGlobalVarFixture.php b/Tests/VariableAnalysisSniff/fixtures/FunctionWithGlobalVarFixture.php index 4874041d..4bbd7dd1 100644 --- a/Tests/VariableAnalysisSniff/fixtures/FunctionWithGlobalVarFixture.php +++ b/Tests/VariableAnalysisSniff/fixtures/FunctionWithGlobalVarFixture.php @@ -57,3 +57,17 @@ function globalWithUnusedFunctionArg($user_type, $text, $testvar) { // should wa } echo $sunday; + +function function_with_reserved_variables() { + $opts = []; + $url = 'https://example.com/'; + $context = stream_context_create($opts); + $response = @file_get_contents($url, false, $context); + $response_headers = handle_response_headers($http_response_header); + return [ + $response, + $response_headers, + $php_errormsg, + $HTTP_RAW_POST_DATA, + ]; +} From cae2fa89849b6dbb1dfa7368272954c01f4a077a Mon Sep 17 00:00:00 2001 From: Payton Swick Date: Tue, 15 Sep 2020 11:43:57 -0400 Subject: [PATCH 2/2] Add missing superglobals to VariableAnalysisSniff --- VariableAnalysis/Sniffs/CodeAnalysis/VariableAnalysisSniff.php | 3 +++ 1 file changed, 3 insertions(+) diff --git a/VariableAnalysis/Sniffs/CodeAnalysis/VariableAnalysisSniff.php b/VariableAnalysis/Sniffs/CodeAnalysis/VariableAnalysisSniff.php index 332a0107..042aa978 100644 --- a/VariableAnalysis/Sniffs/CodeAnalysis/VariableAnalysisSniff.php +++ b/VariableAnalysis/Sniffs/CodeAnalysis/VariableAnalysisSniff.php @@ -799,6 +799,9 @@ protected function processVariableAsSuperGlobal($varName) { '_ENV', 'argv', 'argc', + 'php_errormsg', + 'http_response_header', + 'HTTP_RAW_POST_DATA', ])) { return true; }