From cd736598da46b48677569e02bffd10f7656f2498 Mon Sep 17 00:00:00 2001 From: Andy Lu Date: Wed, 31 Jul 2019 17:28:59 +0000 Subject: [PATCH 1/3] Fix locale issues --- .circleci/config.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.circleci/config.yml b/.circleci/config.yml index a0580f0..26c76f1 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -10,6 +10,7 @@ jobs: command: | aws s3 cp s3://com-stitchdata-dev-deployment-assets/environments/tap-tester/sandbox dev_env.sh source dev_env.sh + export LC_ALL=C python3 -m venv /usr/local/share/virtualenvs/tap-postgres source /usr/local/share/virtualenvs/tap-postgres/bin/activate pip install . From c0c02aaf68f29b1336ab024e19a0474a0967d63c Mon Sep 17 00:00:00 2001 From: Andy Lu Date: Wed, 31 Jul 2019 17:45:22 +0000 Subject: [PATCH 2/3] Change variable name to not override a module name to make pylint happy --- tap_postgres/sync_strategies/logical_replication.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tap_postgres/sync_strategies/logical_replication.py b/tap_postgres/sync_strategies/logical_replication.py index d857f82..bddf10c 100644 --- a/tap_postgres/sync_strategies/logical_replication.py +++ b/tap_postgres/sync_strategies/logical_replication.py @@ -134,8 +134,8 @@ def create_array_elem(elem, sql_datatype, conn_info): #custom datatypes like enums cast_datatype = 'text[]' - sql = """SELECT $stitch_quote${}$stitch_quote$::{}""".format(elem, cast_datatype) - cur.execute(sql) + sql_stmt = """SELECT $stitch_quote${}$stitch_quote$::{}""".format(elem, cast_datatype) + cur.execute(sql_stmt) res = cur.fetchone()[0] return res From 362b803efe9a01cf42e9628428a7ae2773442020 Mon Sep 17 00:00:00 2001 From: Andy Lu Date: Thu, 1 Aug 2019 19:51:23 +0000 Subject: [PATCH 3/3] Revert the addition of the catalog flag --- tap_postgres/__init__.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tap_postgres/__init__.py b/tap_postgres/__init__.py index 00afb6c..38dfe6a 100644 --- a/tap_postgres/__init__.py +++ b/tap_postgres/__init__.py @@ -691,9 +691,9 @@ def main_impl(): if args.discover: do_discovery(conn_config) - elif args.properties or args.catalog: + elif args.properties: state = args.state - do_sync(conn_config, args.catalog.to_dict() if args.catalog else args.properties, args.config.get('default_replication_method'), state) + do_sync(conn_config, args.properties, args.config.get('default_replication_method'), state) else: LOGGER.info("No properties were selected")