Skip to content

Commit 9c429d0

Browse files
committed
Only use authenticated endpoints during EE integration testing (#3253)
## Issue Addressed Failures in our CI integration tests for Geth. ## Proposed Changes Only connect to the authenticated execution endpoints during execution tests. This is necessary now that it is impossible to connect to the `engine` api on an unauthenticated endpoint. See ethereum/go-ethereum#24997 ## Additional Info As these tests break semi-regularly, I have kept logs enabled to ease future debugging. I've also updated the Nethermind tests, although these weren't broken. This should future-proof us if Nethermind decides to follow suit with Geth
1 parent cfd26d2 commit 9c429d0

File tree

4 files changed

+8
-11
lines changed

4 files changed

+8
-11
lines changed

testing/execution_engine_integration/src/execution_engine.rs

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@ pub struct ExecutionEngine<E> {
2222
engine: E,
2323
#[allow(dead_code)]
2424
datadir: TempDir,
25-
http_port: u16,
2625
http_auth_port: u16,
2726
child: Child,
2827
}
@@ -46,16 +45,11 @@ impl<E: GenericExecutionEngine> ExecutionEngine<E> {
4645
Self {
4746
engine,
4847
datadir,
49-
http_port,
5048
http_auth_port,
5149
child,
5250
}
5351
}
5452

55-
pub fn http_url(&self) -> SensitiveUrl {
56-
SensitiveUrl::parse(&format!("http://127.0.0.1:{}", self.http_port)).unwrap()
57-
}
58-
5953
pub fn http_auth_url(&self) -> SensitiveUrl {
6054
SensitiveUrl::parse(&format!("http://127.0.0.1:{}", self.http_auth_port)).unwrap()
6155
}

testing/execution_engine_integration/src/main.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ use nethermind::NethermindEngine;
1515
use test_rig::TestRig;
1616

1717
/// Set to `false` to send logs to the console during tests. Logs are useful when debugging.
18-
const SUPPRESS_LOGS: bool = true;
18+
const SUPPRESS_LOGS: bool = false;
1919

2020
fn main() {
2121
if cfg!(windows) {

testing/execution_engine_integration/src/nethermind.rs

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ impl GenericExecutionEngine for NethermindEngine {
7575

7676
fn start_client(
7777
datadir: &TempDir,
78-
http_port: u16,
78+
_http_port: u16,
7979
http_auth_port: u16,
8080
jwt_secret_path: PathBuf,
8181
) -> Child {
@@ -89,11 +89,14 @@ impl GenericExecutionEngine for NethermindEngine {
8989
.arg("--Merge.TerminalTotalDifficulty")
9090
.arg("0")
9191
.arg("--JsonRpc.AdditionalRpcUrls")
92-
.arg(format!("http://localhost:{}|http;ws|net;eth;subscribe;engine;web3;client|no-auth,http://localhost:{}|http;ws|net;eth;subscribe;engine;web3;client", http_port, http_auth_port))
92+
.arg(format!(
93+
"http://localhost:{}|http;ws|net;eth;subscribe;engine;web3;client",
94+
http_auth_port
95+
))
9396
.arg("--JsonRpc.EnabledModules")
9497
.arg("net,eth,subscribe,web3,admin,engine")
9598
.arg("--JsonRpc.Port")
96-
.arg(http_port.to_string())
99+
.arg(http_auth_port.to_string())
97100
.arg("--Network.DiscoveryPort")
98101
.arg(network_port.to_string())
99102
.arg("--Network.P2PPort")

testing/execution_engine_integration/src/test_rig.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ impl<E: GenericExecutionEngine> TestRig<E> {
6868

6969
let ee_b = {
7070
let execution_engine = ExecutionEngine::new(generic_engine);
71-
let urls = vec![execution_engine.http_url()];
71+
let urls = vec![execution_engine.http_auth_url()];
7272

7373
let config = execution_layer::Config {
7474
execution_endpoints: urls,

0 commit comments

Comments
 (0)