From 1a84a566074cb86dff59d6cea7b736436af7187b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pawe=C5=82=20Lewtak?= Date: Thu, 26 Oct 2017 23:31:26 +0200 Subject: [PATCH 1/2] Create Pull Request Template Fixes #46 --- .github/PULL_REQUEST_TEMPLATE.md | 37 ++++++++++++++++++++++++++++++++ 1 file changed, 37 insertions(+) create mode 100644 .github/PULL_REQUEST_TEMPLATE.md diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md new file mode 100644 index 0000000..86989fc --- /dev/null +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -0,0 +1,37 @@ + + +**Description of the change**: + +**Reason for the change**: + +**Link to original source**: + +### Checklist + +Make sure all of these items are complete, or else the PR will be ineligible for a code review. + +- [ ] Code passes all existing [tests](https://github.com/sendgrid/php-http-client/tree/master/test) +- [ ] Any new functionality added includes new unit tests in [`tests/unit`](https://github.com/sendgrid/php-http-client/tree/master/test/unit) +- [ ] Create or update example code to show the new functionality in action. +- [ ] All code, branch, and git naming and style conventions are followed (see [`CONTRIBUTING.md`](https://github.com/sendgrid/php-http-client/blob/master/CONTRIBUTING.md#style-guidelines-and-naming-conventions)) +- [ ] Feature branch has been rebased off of the latest `master` branch. (see [`CONTRIBUTING.md`](https://github.com/sendgrid/php-http-client/blob/master/CONTRIBUTING.md#creating-a-pull-request)). + +If you have questions, please send an email [Sendgrid](mailto:dx@sendgrid.com), or file a Github Issue in this repository. + + From 3d61f24c4c00dce57a8ef6a976d5c36191d78403 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pawe=C5=82=20Lewtak?= Date: Fri, 27 Oct 2017 08:14:59 +0200 Subject: [PATCH 2/2] Remove email address --- .github/PULL_REQUEST_TEMPLATE.md | 2 -- 1 file changed, 2 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 86989fc..e8a2e6a 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -28,8 +28,6 @@ Make sure all of these items are complete, or else the PR will be ineligible for - [ ] All code, branch, and git naming and style conventions are followed (see [`CONTRIBUTING.md`](https://github.com/sendgrid/php-http-client/blob/master/CONTRIBUTING.md#style-guidelines-and-naming-conventions)) - [ ] Feature branch has been rebased off of the latest `master` branch. (see [`CONTRIBUTING.md`](https://github.com/sendgrid/php-http-client/blob/master/CONTRIBUTING.md#creating-a-pull-request)). -If you have questions, please send an email [Sendgrid](mailto:dx@sendgrid.com), or file a Github Issue in this repository. -