Improve DevTools request interception test by loading different JS

p0deje · p0deje · commit c9a2ef6a8803 · 2021-10-11T14:24:01.000-07:00
diff --git a/common/src/web/devToolsRequestInterceptionTest.html b/common/src/web/devToolsRequestInterceptionTest.html
@@ -0,0 +1,15 @@
+<!doctype html>
+
+<html lang="en">
+  <head>
+    <title>DevTools Request Interception Test</title>
+    <script language="javascript" type="text/javascript" src="devtools_request_interception_test/one.js"></script>
+  </head>
+
+  <body>
+    <div id="result"></div>
+    <button onClick="printScriptName()">
+      Click me to print script name
+    </button>
+  </body>
+</html>
diff --git a/common/src/web/devtools_request_interception_test/one.js b/common/src/web/devtools_request_interception_test/one.js
@@ -0,0 +1,3 @@
+function printScriptName() {
+  document.getElementById('result').innerHTML = 'one';
+}
diff --git a/common/src/web/devtools_request_interception_test/two.js b/common/src/web/devtools_request_interception_test/two.js
@@ -0,0 +1,3 @@
+function printScriptName() {
+  document.getElementById('result').innerHTML = 'two';
+}
diff --git a/rb/spec/integration/selenium/webdriver/devtools_spec.rb b/rb/spec/integration/selenium/webdriver/devtools_spec.rb
@@ -167,14 +167,15 @@ module WebDriver
         it 'changes requests' do
           driver.intercept do |request, &continue|
             uri = URI(request.url)
-            if uri.path.match?(%r{/html5/.*\.jpg})
-              uri.path = '/beach.jpg'
+            if uri.path.end_with?('one.js')
+              uri.path = '/devtools_request_interception_test/two.js'
               request.url = uri.to_s
             end
             continue.call(request)
           end
-          driver.navigate.to url_for('html5Page.html')
-          expect(driver.find_elements(tag_name: 'img').map(&:size).uniq).to eq([Dimension.new(640, 480)])
+          driver.navigate.to url_for('devToolsRequestInterceptionTest.html')
+          driver.find_element(tag_name: 'button').click
+          expect(driver.find_element(id: 'result').text).to eq('two')
         end
 
         it 'continues responses' do

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+function printScriptName() {`
	`2`	`+ document.getElementById('result').innerHTML = 'one';`
	`3`	`+}`