Skip to content
This repository was archived by the owner on Dec 11, 2019. It is now read-only.

Commit 9262cd7

Browse files
duellsyjlee9595
authored andcommitted
Remove assumesPageView option (#12)
* Added support for using plan as group * Release 2.1.0 * Added support for using new setUser method This helps to future proof for companies using the latest version of the embeddable * Updated version to 2.2.0 * Re-instating package.json updates that a merge missed * Linting issue Had double quotes instead of single. Sorry. * Changing setUser function exists test to be more explicit * Reversal of setUser function check logic * Updated version to 2.2.0 * Reversal of setUser function check logic * Remove assumesPageView option * Remove assumesPageView option Updated test to remove the call to assumesPageView * Upgrade segment/analytics.js-integration to 3.2 * Updating tests to remove call to page()
1 parent 6155cfd commit 9262cd7

File tree

4 files changed

+7
-6
lines changed

4 files changed

+7
-6
lines changed

HISTORY.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
1+
2.3.0 / 2017-08-23
2+
==================
3+
4+
* Remove assumesPageView option
5+
16
2.2.1 / 2017-08-23
27
==================
38

lib/index.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ var objectKeys = require('@ndhoule/keys');
1111
*/
1212

1313
var Elevio = module.exports = integration('Elevio')
14-
.assumesPageview()
1514
.option('accountId', '')
1615
.global('_elev')
1716
.tag('<script src="//static.elev.io/js/v3.js">');

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "@segment/analytics.js-integration-elevio",
33
"description": "The Elevio analytics.js integration.",
4-
"version": "2.2.1",
4+
"version": "2.3.0",
55
"keywords": [
66
"analytics.js",
77
"analytics.js-integration",
@@ -25,7 +25,7 @@
2525
"dependencies": {
2626
"@ndhoule/each": "^2.0.1",
2727
"@ndhoule/keys": "^2.0.0",
28-
"@segment/analytics.js-integration": "^2.1.0",
28+
"@segment/analytics.js-integration": "^3.2.0",
2929
"next-tick": "^1.0.0",
3030
"obj-case": "^0.2.0"
3131
},

test/index.test.js

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@ describe('Elevio', function() {
3030

3131
it('should have the right settings', function() {
3232
analytics.compare(Elevio, integration('Elevio')
33-
.assumesPageview()
3433
.global('_elev')
3534
.option('accountId', ''));
3635
});
@@ -43,12 +42,10 @@ describe('Elevio', function() {
4342
describe('#initialize', function() {
4443
it('should create window._elev', function() {
4544
analytics.initialize();
46-
analytics.page();
4745
analytics.assert(window._elev instanceof Object);
4846
});
4947
it('should call #load', function() {
5048
analytics.initialize();
51-
analytics.page();
5249
analytics.called(elevio.load);
5350
});
5451
});

0 commit comments

Comments
 (0)