Skip to content

Commit 7748995

Browse files
committed
fixing according to reviews
1 parent 79cc030 commit 7748995

File tree

5 files changed

+13
-14
lines changed

5 files changed

+13
-14
lines changed

coordinator/cmd/tool/verify.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,6 +113,6 @@ func verify(cCtx *cli.Context) error {
113113
if err != nil {
114114
return err
115115
}
116-
fmt.Println("verified:", ret)
116+
log.Info("verified:", "ret", ret)
117117
return nil
118118
}

coordinator/conf/config.json

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,9 @@
77
"batch_collection_time_sec": 180,
88
"chunk_collection_time_sec": 180,
99
"verifier": {
10-
"assets_path": "assets",
1110
"min_prover_version": "v4.4.45",
12-
"accept_vks": [{
13-
"file": "euclidvk.json",
11+
"verifiers": [{
12+
"assets_path": "assets",
1413
"fork_name": "euclidV2"
1514
}]
1615
}

coordinator/internal/config/config_test.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,11 +20,11 @@ func TestConfig(t *testing.T) {
2020
"batch_collection_time_sec": 180,
2121
"chunk_collection_time_sec": 180,
2222
"verifier": {
23-
"high_version_circuit": {
23+
"min_prover_version": "v4.4.45",
24+
"verifiers": [{
2425
"assets_path": "assets",
25-
"fork_name": "euclidV2",
26-
"min_prover_version": "v4.4.45"
27-
}
26+
"fork_name": "euclidV2"
27+
}]
2828
},
2929
"max_verifier_workers": 4
3030
},

coordinator/internal/logic/verifier/verifier_test.go

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -29,11 +29,11 @@ func TestFFI(t *testing.T) {
2929
as := assert.New(t)
3030

3131
cfg := &config.VerifierConfig{
32-
HighVersionCircuit: &config.CircuitConfig{
33-
AssetsPath: *assetsPathHi,
34-
ForkName: "euclidV2",
35-
MinProverVersion: "",
36-
},
32+
MinProverVersion: "",
33+
Verifiers: []config.AssetConfig{{
34+
AssetsPath: *assetsPathHi,
35+
ForkName: "euclidV2",
36+
}},
3737
}
3838

3939
v, err := NewVerifier(cfg)

crates/libzkp/src/proofs.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -192,7 +192,7 @@ impl<Metadata: ProofMetadata> WrappedProof<Metadata> {
192192
.map(|&v| v as u32)
193193
.collect::<Vec<_>>();
194194

195-
let ret = expected_pi != proof_pi;
195+
let ret = expected_pi == proof_pi;
196196
if !ret {
197197
tracing::warn!("pi mismatch: expected={expected_pi:?}, found={proof_pi:?}");
198198
}

0 commit comments

Comments
 (0)