update P256Verify

Author: georgehao

core/vm/contracts_test.go

@@ -412,9 +412,7 @@ func BenchmarkPrecompiledP256Verify(bench *testing.B) {
 		Expected: "0000000000000000000000000000000000000000000000000000000000000001",
 		Name:     "p256Verify",
 	}
-	benchmarkPrecompiled("100", t, bench)
+	benchmarkPrecompiled("0b", t, bench)
 }
 
-func TestPrecompiledP256Verify(t *testing.T) {
-	testJson("p256Verify", "100", t)
-}
+func TestPrecompiledP256Verify(t *testing.T) { testJson("p256Verify", "0b", t) }

crypto/secp256r1/verifier.go

@@ -2,21 +2,15 @@ package secp256r1
 
 import (
 	"crypto/ecdsa"
+	"crypto/elliptic"
 	"math/big"
 )
 
-// Verify verifies the given signature (r, s) for the given hash and public key (x, y).
-// It returns true if the signature is valid, false otherwise.
+// Verify checks the given signature (r, s) for the given hash and public key (x, y).
 func Verify(hash []byte, r, s, x, y *big.Int) bool {
-	// Create the public key format
-	publicKey := newPublicKey(x, y)
-
-	// Check if they are invalid public key coordinates
-	if publicKey == nil {
+	if x == nil || y == nil || !elliptic.P256().IsOnCurve(x, y) {
 		return false
 	}
-
-	// Verify the signature with the public key,
-	// then return true if it's valid, false otherwise
-	return ecdsa.Verify(publicKey, hash, r, s)
+	pk := &ecdsa.PublicKey{Curve: elliptic.P256(), X: x, Y: y}
+	return ecdsa.Verify(pk, hash, r, s)
 }

params/protocol_params.go

@@ -162,7 +162,7 @@ const (
 	Bls12381MapG1Gas          uint64 = 5500   // Gas price for BLS12-381 mapping field element to G1 operation
 	Bls12381MapG2Gas          uint64 = 110000 // Gas price for BLS12-381 mapping field element to G2 operation
 
-	P256VerifyGas uint64 = 3450 // secp256r1 elliptic curve signature verifier gas price
+	P256VerifyGas uint64 = 6900 // secp256r1 elliptic curve signature verifier gas price
 
 	// The Refund Quotient is the cap on how much of the used gas can be refunded. Before EIP-3529,
 	// up to half the consumed gas could be refunded. Redefined as 1/5th in EIP-3529