Skip to content

Commit 4e6f759

Browse files
committed
address review comments
1 parent e51182d commit 4e6f759

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

rollup/da_syncer/da/calldata_blob_source.go

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ type CalldataBlobSource struct {
2626
ctx context.Context
2727
l1Reader *l1.Reader
2828
blobClient blob_client.BlobClient
29-
l1height uint64
29+
l1Height uint64
3030
scrollChainABI *abi.ABI
3131
db ethdb.Database
3232

@@ -42,15 +42,15 @@ func NewCalldataBlobSource(ctx context.Context, l1height uint64, l1Reader *l1.Re
4242
ctx: ctx,
4343
l1Reader: l1Reader,
4444
blobClient: blobClient,
45-
l1height: l1height,
45+
l1Height: l1height,
4646
scrollChainABI: scrollChainABI,
4747
db: db,
4848
}, nil
4949
}
5050

5151
func (ds *CalldataBlobSource) NextData() (Entries, error) {
5252
var err error
53-
to := ds.l1height + callDataBlobSourceFetchBlockRange
53+
to := ds.l1Height + callDataBlobSourceFetchBlockRange
5454

5555
// If there's not enough finalized blocks to request up to, we need to query finalized block number.
5656
// Otherwise, we know that there's more finalized blocks than we want to request up to
@@ -64,25 +64,25 @@ func (ds *CalldataBlobSource) NextData() (Entries, error) {
6464
to = min(to, ds.l1Finalized)
6565
}
6666

67-
if ds.l1height > to {
67+
if ds.l1Height > to {
6868
return nil, ErrSourceExhausted
6969
}
7070

71-
rollupEvents, err := ds.l1Reader.FetchRollupEventsInRange(ds.l1height, to)
71+
rollupEvents, err := ds.l1Reader.FetchRollupEventsInRange(ds.l1Height, to)
7272
if err != nil {
73-
return nil, serrors.NewTemporaryError(fmt.Errorf("cannot get rollup events, l1height: %d, error: %v", ds.l1height, err))
73+
return nil, serrors.NewTemporaryError(fmt.Errorf("cannot get rollup events, l1Height: %d, error: %v", ds.l1Height, err))
7474
}
7575
da, err := ds.processRollupEventsToDA(rollupEvents)
7676
if err != nil {
7777
return nil, serrors.NewTemporaryError(fmt.Errorf("failed to process rollup events to DA, error: %v", err))
7878
}
7979

80-
ds.l1height = to + 1
80+
ds.l1Height = to + 1
8181
return da, nil
8282
}
8383

8484
func (ds *CalldataBlobSource) L1Height() uint64 {
85-
return ds.l1height
85+
return ds.l1Height
8686
}
8787

8888
func (ds *CalldataBlobSource) processRollupEventsToDA(rollupEvents l1.RollupEvents) (Entries, error) {

0 commit comments

Comments
 (0)