feat: include L1 message with insufficient balance

Author: Thegaram

core/state_transition.go

@@ -359,7 +359,7 @@ func (st *StateTransition) TransitionDb() (*ExecutionResult, error) {
 	st.gas -= gas
 
 	// Check clause 6
-	if msg.Value().Sign() > 0 && !st.evm.Context.CanTransfer(st.state, msg.From(), msg.Value()) {
+	if msg.Value().Sign() > 0 && !st.evm.Context.CanTransfer(st.state, msg.From(), msg.Value()) && !msg.IsL1MessageTx() {
 		return nil, fmt.Errorf("%w: address %v", ErrInsufficientFundsForTransfer, msg.From().Hex())
 	}
 

miner/worker_test.go

@@ -732,7 +732,7 @@ func TestL1MsgCorrectOrder(t *testing.T) {
 	}
 }
 
-func l1MessageTest(t *testing.T, msgs []types.L1MessageTx, callback func(i int, block *types.Block, db ethdb.Database) bool) {
+func l1MessageTest(t *testing.T, msgs []types.L1MessageTx, callback func(i int, block *types.Block, db ethdb.Database, bc *core.BlockChain) bool) {
 	var (
 		engine      consensus.Engine
 		chainConfig *params.ChainConfig
@@ -784,8 +784,8 @@ func l1MessageTest(t *testing.T, msgs []types.L1MessageTx, callback func(i int,
 		select {
 		case ev := <-sub.Chan():
 			block := ev.Data.(core.NewMinedBlockEvent).Block
-			// TODO
-			if callback(ii, block, db) {
+
+			if done := callback(ii, block, db, chain); done {
 				return
 			}
 
@@ -805,7 +805,7 @@ func TestL1SingleMessageOverGasLimit(t *testing.T) {
 		{QueueIndex: 2, Gas: 21016, To: &common.Address{1}, Data: []byte{0x01}, Sender: common.Address{3}},    // different sender
 	}
 
-	l1MessageTest(t, msgs, func(_i int, block *types.Block, db ethdb.Database) bool {
+	l1MessageTest(t, msgs, func(_ int, block *types.Block, db ethdb.Database, _ *core.BlockChain) bool {
 		// skip #0, include #1 and #2
 		assert.Equal(2, len(block.Transactions()))
 
@@ -834,7 +834,7 @@ func TestL1CombinedMessagesOverGasLimit(t *testing.T) {
 		{QueueIndex: 2, Gas: 21016, To: &common.Address{1}, Data: []byte{0x01}, Sender: common.Address{3}},   // different sender
 	}
 
-	l1MessageTest(t, msgs, func(blockNum int, block *types.Block, db ethdb.Database) bool {
+	l1MessageTest(t, msgs, func(blockNum int, block *types.Block, db ethdb.Database, _ *core.BlockChain) bool {
 		switch blockNum {
 		case 1:
 			// block #1 only includes 1 message
@@ -876,7 +876,7 @@ func TestLargeL1MessageSkipPayloadCheck(t *testing.T) {
 		{QueueIndex: 2, Gas: 21016, To: &common.Address{1}, Data: []byte{0x01}, Sender: common.Address{3}}, // different sender
 	}
 
-	l1MessageTest(t, msgs, func(blockNum int, block *types.Block, db ethdb.Database) bool {
+	l1MessageTest(t, msgs, func(blockNum int, block *types.Block, db ethdb.Database, _ *core.BlockChain) bool {
 		// include #0, #1 and #2
 		assert.Equal(3, len(block.Transactions()))
 
@@ -895,3 +895,31 @@ func TestLargeL1MessageSkipPayloadCheck(t *testing.T) {
 		return true
 	})
 }
+
+func TestL1MessageWithInsufficientBalanceNotSkipped(t *testing.T) {
+	assert := assert.New(t)
+
+	// message #0 sends more funds than available in the sender account
+	msgs := []types.L1MessageTx{
+		{QueueIndex: 0, Gas: 25100, To: &common.Address{1}, Data: make([]byte, 1025), Sender: common.Address{2}, Value: big.NewInt(1)},
+	}
+
+	l1MessageTest(t, msgs, func(blockNum int, block *types.Block, db ethdb.Database, bc *core.BlockChain) bool {
+		// include #0
+		assert.Equal(1, len(block.Transactions()))
+		assert.True(block.Transactions()[0].IsL1MessageTx())
+		assert.Equal(uint64(0), block.Transactions()[0].AsL1MessageTx().QueueIndex)
+
+		// failing receipt is stored correctly
+		receipts := bc.GetReceiptsByHash(block.Hash())
+		assert.Equal(1, len(receipts))
+		assert.Equal(types.ReceiptStatusFailed, receipts[0].Status)
+
+		// db is updated correctly
+		queueIndex := rawdb.ReadFirstQueueIndexNotInL2Block(db, block.Hash())
+		assert.NotNil(queueIndex)
+		assert.Equal(uint64(1), *queueIndex)
+
+		return true
+	})
+}