address comments

Author: colinlyguo

encoding/codecv0.go

@@ -60,9 +60,6 @@ func (d *DACodecV0) NewDABlock(block *Block, totalL1MessagePoppedBefore uint64)
 
 // NewDAChunk creates a new DAChunk from the given Chunk and the total number of L1 messages popped before.
 func (d *DACodecV0) NewDAChunk(chunk *Chunk, totalL1MessagePoppedBefore uint64) (DAChunk, error) {
-	var blocks []DABlock
-	var txs [][]*types.TransactionData
-
 	if chunk == nil {
 		return nil, errors.New("chunk is nil")
 	}
@@ -75,6 +72,9 @@ func (d *DACodecV0) NewDAChunk(chunk *Chunk, totalL1MessagePoppedBefore uint64)
 		return nil, fmt.Errorf("number of blocks (%d) exceeds maximum allowed (%d)", len(chunk.Blocks), math.MaxUint8)
 	}
 
+	blocks := make([]DABlock, 0, len(chunk.Blocks))
+	txs := make([][]*types.TransactionData, 0, len(chunk.Blocks))
+
 	for _, block := range chunk.Blocks {
 		b, err := d.NewDABlock(block, totalL1MessagePoppedBefore)
 		if err != nil {
@@ -97,7 +97,7 @@ func (d *DACodecV0) NewDAChunk(chunk *Chunk, totalL1MessagePoppedBefore uint64)
 
 // DecodeDAChunksRawTx takes a byte slice and decodes it into a []*DAChunkRawTx.
 func (d *DACodecV0) DecodeDAChunksRawTx(chunkBytes [][]byte) ([]*DAChunkRawTx, error) {
-	var chunks []*DAChunkRawTx
+	chunks := make([]*DAChunkRawTx, 0, len(chunkBytes))
 	for _, chunk := range chunkBytes {
 		if len(chunk) < 1 {
 			return nil, fmt.Errorf("invalid chunk, length is less than 1")

encoding/codecv0_types.go

@@ -237,7 +237,7 @@ func newDABatchV0(version uint8, batchIndex, l1MessagePopped, totalL1MessagePopp
 
 // Encode serializes the DABatchV0 into bytes.
 func (b *daBatchV0) Encode() []byte {
-	batchBytes := make([]byte, daBatchV0OffsetSkippedL1MessageBitmap+len(b.skippedL1MessageBitmap))
+	batchBytes := make([]byte, daBatchV0EncodedMinLength+len(b.skippedL1MessageBitmap))
 	batchBytes[daBatchOffsetVersion] = b.version
 	binary.BigEndian.PutUint64(batchBytes[daBatchOffsetBatchIndex:daBatchV0OffsetL1MessagePopped], b.batchIndex)
 	binary.BigEndian.PutUint64(batchBytes[daBatchV0OffsetL1MessagePopped:daBatchV0OffsetTotalL1MessagePopped], b.l1MessagePopped)

encoding/codecv1.go

@@ -25,9 +25,6 @@ func (d *DACodecV1) Version() CodecVersion {
 
 // NewDAChunk creates a new DAChunk from the given Chunk and the total number of L1 messages popped before.
 func (d *DACodecV1) NewDAChunk(chunk *Chunk, totalL1MessagePoppedBefore uint64) (DAChunk, error) {
-	var blocks []DABlock
-	var txs [][]*types.TransactionData
-
 	if chunk == nil {
 		return nil, errors.New("chunk is nil")
 	}
@@ -40,6 +37,9 @@ func (d *DACodecV1) NewDAChunk(chunk *Chunk, totalL1MessagePoppedBefore uint64)
 		return nil, fmt.Errorf("number of blocks (%d) exceeds maximum allowed (%d)", len(chunk.Blocks), math.MaxUint8)
 	}
 
+	blocks := make([]DABlock, 0, len(chunk.Blocks))
+	txs := make([][]*types.TransactionData, 0, len(chunk.Blocks))
+
 	for _, block := range chunk.Blocks {
 		b, err := d.NewDABlock(block, totalL1MessagePoppedBefore)
 		if err != nil {
@@ -60,9 +60,9 @@ func (d *DACodecV1) NewDAChunk(chunk *Chunk, totalL1MessagePoppedBefore uint64)
 
 // DecodeDAChunksRawTx takes a byte slice and decodes it into a []*DAChunkRawTx.
 // Beginning from codecv1 tx data posted to blobs, not to chunk bytes in calldata
-func (d *DACodecV1) DecodeDAChunksRawTx(bytes [][]byte) ([]*DAChunkRawTx, error) {
-	var chunks []*DAChunkRawTx
-	for _, chunk := range bytes {
+func (d *DACodecV1) DecodeDAChunksRawTx(chunkBytes [][]byte) ([]*DAChunkRawTx, error) {
+	chunks := make([]*DAChunkRawTx, 0, len(chunkBytes))
+	for _, chunk := range chunkBytes {
 		if len(chunk) < 1 {
 			return nil, fmt.Errorf("invalid chunk, length is less than 1")
 		}

encoding/codecv1_types.go

@@ -103,7 +103,7 @@ func newDABatchV1(version uint8, batchIndex, l1MessagePopped, totalL1MessagePopp
 
 // Encode serializes the DABatchV1 into bytes.
 func (b *daBatchV1) Encode() []byte {
-	batchBytes := make([]byte, daBatchV1OffsetSkippedL1MessageBitmap+len(b.skippedL1MessageBitmap))
+	batchBytes := make([]byte, daBatchV1EncodedMinLength+len(b.skippedL1MessageBitmap))
 	batchBytes[daBatchOffsetVersion] = b.version
 	binary.BigEndian.PutUint64(batchBytes[daBatchOffsetBatchIndex:daBatchV1OffsetL1MessagePopped], b.batchIndex)
 	binary.BigEndian.PutUint64(batchBytes[daBatchV1OffsetL1MessagePopped:daBatchV1OffsetTotalL1MessagePopped], b.l1MessagePopped)