refactor: some cosmetics changes

Author: Artem Kajalainen

locals.tf

@@ -1,8 +1,5 @@
 locals {
-  # default to namespace for backwards compatibility
-  pre_stack_prefix = "${var.namespace}-${var.env}-"
-  stack_prefix     = local.pre_stack_prefix == "${var.namespace}--" ? "" : local.pre_stack_prefix
-
+  stack_prefix = var.env == "" ? "" : "${join("-", compact([var.namespace, var.env]))}-"
   default_tags = {
     env       = var.env
     namespace = var.namespace

logs_monitoring.tf

@@ -11,7 +11,7 @@ resource aws_cloudformation_stack "datadog-forwarder" {
 }
 
 resource aws_secretsmanager_secret "datadog_api_key" {
-  name        = "${local.stack_prefix}datadog_api_key"
+  name        = "${local.stack_prefix}datadog-api-key"
   description = "Datadog API Key"
   tags        = local.default_tags
 }