-
Notifications
You must be signed in to change notification settings - Fork 1.3k
MNT move ROSE into RandomOverSampler with addititional parameters #791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MNT move ROSE into RandomOverSampler with addititional parameters #791
Conversation
Codecov Report
@@ Coverage Diff @@
## master #791 +/- ##
=======================================
Coverage 98.58% 98.58%
=======================================
Files 89 89
Lines 5721 5721
Branches 477 477
=======================================
Hits 5640 5640
Misses 80 80
Partials 1 1 Continue to review full report at Codecov.
|
|
Hello @glemaitre! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2021-02-12 10:24:27 UTC |
|
This pull request introduces 4 alerts when merging b1d8714 into 9b666a0 - view on LGTM.com new alerts:
|
| .. versionadded:: 0.7 | ||
| shrinkage : float or dict, default=1.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this bounded?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nop
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh yes negative don't make sense sorry
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will update in the new PR.
|
This pull request introduces 4 alerts when merging 112add4 into 9b666a0 - view on LGTM.com new alerts:
|
closes #792
This PR intends to:
ROSEin theRandomOverSamplerby adding 2 parameters:smoothed_bootstrapandshrinkage.ROSEclassRandomOverSampler.shrinkageis adict