DOC improve documentation for RENN and AllKNN #1022
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@glemaitre ready for review |
glemaitre
changed the title
glemaitre
reviewed
Jul 10, 2023
doc/under_sampling.rst
Outdated
| is determined by the user through the parameter ``n_neighbors` is reached, or when the | ||
| majority class becomes the minority class. | ||
| In the example below, we see that ENN, RENN and AllKNN have similar impact when |
Member
There was a problem hiding this comment.
Could we refer to the class when presenting ENN RENN AlKNN:
:class:`EditedNearestNeighbours`, etc.
Co-authored-by: Guillaume Lemaitre <[email protected]>
Co-authored-by: Guillaume Lemaitre <[email protected]>
Contributor
Author
|
done |
glemaitre
approved these changes
Jul 11, 2023
Member
glemaitre
left a comment
glemaitre
left a comment
There was a problem hiding this comment.
LGTM. I will just wait for the doc CI to complete to check that we did not break the hyperlinks.
Member
|
The failure is not related. Merging. Thanks @solegalli |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #850
separating in smaller PRs as requested.