Skip to content

Commit 6196aae

Browse files
committed
Install ninja, which fixes the build error
1 parent f5e7c95 commit 6196aae

File tree

1 file changed

+13
-14
lines changed

1 file changed

+13
-14
lines changed

tests/test_editable.py

Lines changed: 13 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -72,30 +72,29 @@ def test_cython_pxd(monkeypatch, tmp_path, editable):
7272
env.install("pip>=23")
7373
env.install("cython")
7474
env.install("scikit-build-core[pyproject]")
75+
env.install("ninja")
7576

76-
# This succeeds
7777
env.install(
78-
"-v", "--config-settings=build-dir=build/{wheel_tag}", *editable_flag, "."
78+
"-v",
79+
"--config-settings=build-dir=build/{wheel_tag}",
80+
"--no-build-isolation",
81+
*editable_flag,
82+
".",
83+
)
84+
85+
package2 = PackageInfo(
86+
"cython_pxd_editable/pkg2",
7987
)
88+
tmp_path2 = tmp_path / "pkg2"
89+
tmp_path2.mkdir()
90+
process_package(package2, tmp_path2, monkeypatch)
8091

81-
# This fails
8292
env.install(
8393
"-v",
8494
"--config-settings=build-dir=build/{wheel_tag}",
8595
"--no-build-isolation",
8696
*editable_flag,
8797
".",
8898
)
89-
90-
# package2 = PackageInfo(
91-
# "cython_pxd_editable/pkg2",
92-
# )
93-
# tmp_path2 = tmp_path / "pkg2"
94-
# tmp_path2.mkdir()
95-
# process_package(package2, tmp_path2, monkeypatch)
96-
#
97-
# env.install(
98-
# "-v", "--config-settings=build-dir=build/{wheel_tag}", "--no-build-isolation", *editable_flag, "."
99-
# )
10099
finally:
101100
shutil.rmtree(env_path, ignore_errors=True)

0 commit comments

Comments
 (0)