Add case-class-companion incompatibility #138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adpi2
force-pushed
the
case-class-companion
branch
from
14e30ea to
76b4cd2
Compare
julienrf
approved these changes
Feb 16, 2021
Contributor
julienrf
left a comment
julienrf
left a comment
There was a problem hiding this comment.
Nice workaround, thanks Adrien!
adpi2
force-pushed
the
case-class-companion
branch
from
76b4cd2 to
0eb008a
Compare
Contributor
|
I wonder if scala/scala3#7207 fixed the problem? |
Contributor
|
We will see after the migration to 3.0.0-RC1 if the incompatibility is still incompatible :) |
Member
Author
|
Apparently it does not fix the problem. Indeed, all the incompatibilities in this repo, including this one are tested. We check that the I think the PR you mention allows to write this: Foo.apply.tupled((1,true))
Foo.apply.curried(2)(false)But this doesn't compile in 2.13 because the eta-expansion only occurs when a function type is expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #122